Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update polkadot-sdk dependencies to v1.0 #266

Merged
merged 4 commits into from
Dec 25, 2024
Merged

Conversation

F3Joule
Copy link
Member

@F3Joule F3Joule commented Dec 11, 2024

Release Checklist

  • Verify spec_version has been incremented since the last release.
  • Verify pallet and extrinsic ordering has stayed the same. Bump transaction_version if not.
  • Verify new extrinsics have been correctly whitelisted/blacklisted for BaseCallFilter
  • There are benchmarks for newly created extrinsics.
  • Verify weights have been updated for any modified runtime logic.
  • There are tests for newly created logic.
  • All the tests pass.
  • Ensure migrations run correctly.

Change Substrate, Polkadot and Cumulus deps to v1.0
@F3Joule F3Joule self-assigned this Dec 11, 2024
@F3Joule F3Joule requested a review from siman December 11, 2024 16:12
@F3Joule F3Joule added CI Add this label to PR that should run CI to build a new parachain docker image feature-release A new feature PR ready to release labels Dec 11, 2024
* Fix failing mocks and tests

- Fix energy mocks and tests
- Fix domains mocks
- Fix creator staking mocks

* Update spec_version to 45

* Update transaction_version to 10

* Remove unnecessary migration

* Add missing migrations

* Remove redundant Github action

* Fix evm-addresses pallet build

* Add migration for pallet-xcm

- Fix benchmarking script
@F3Joule F3Joule marked this pull request as ready for review December 24, 2024 18:33
@F3Joule
Copy link
Member Author

F3Joule commented Dec 24, 2024

Try-runtime results:

2024-12-24 20:07:49 initialized state externalities with storage root 0xa3e25f2a36057326e465502c0d1fb93cba5303ff1d835f29358d51eac15a2aac and state_version V0
2024-12-24 20:07:49 original spec: RuntimeString::Owned("subsocial-parachain")-44, code hash: dc500654f1dbf062193354f214f911d4ea359ac7b16a4bd4426707b764dd6985
2024-12-24 20:07:49 new spec: RuntimeString::Owned("subsocial-parachain")-45, code hash: 3093b0ccf74f77c9cbc2e3c011a6671f4e93d1dab92d09e91b849df1c56fb98c
2024-12-24 20:07:50 Sorted 3 Invulnerables, upgraded storage to version 1
2024-12-24 20:07:50 [6766298] ✍️ Number of calls to refund and delete: 0
2024-12-24 20:07:50 v1 applied successfully
2024-12-24 20:07:50 Storage to version 1
2024-12-24 20:07:50 ⚠️ PolkadotXcm declares internal migrations (which *might* execute). On-chain `StorageVersion(1)` vs current storage version `StorageVersion(1)`
2024-12-24 20:07:50 TryRuntime_on_runtime_upgrade executed without errors. Consumed weight = (0 ps, 0 byte), total weight = (500000000000 ps, 5242880 byte) (0.00 %, 0.00 %).

@F3Joule
Copy link
Member Author

F3Joule commented Dec 24, 2024

Metadata comparison:
Date: Tue Dec 24 20:50:42 EET 2024
Reference: wss://para.subsocial.network
Target version: subsocial-collator 0.3.0-ddccfe8a914
Chain: dev
----------------------------------------------------------------------
              [Spec] name: subsocial-parachain
                     spec_version: 44 -> 45
                     transaction_version: 9 -> 10
          [Metadata] version: 14
           [Modules] num: 38
                          [System] idx: 0 (calls: 8, storage: 17)
                 [ParachainSystem] idx: 1 (calls: 4, storage: 22)
                                [validationData] type: Option<PolkadotPrimitivesV2PersistedValidationData> -> Option<PolkadotPrimitivesV5PersistedValidationData>
                      [upgradeRestrictionSignal] type: Option<PolkadotPrimitivesV2UpgradeRestriction> -> Option<PolkadotPrimitivesV5UpgradeRestriction>
                             [hostConfiguration] type: Option<PolkadotPrimitivesV2AbridgedHostConfiguration> -> Option<PolkadotPrimitivesV5AbridgedHostConfiguration>
                       [Timestamp] idx: 3 (calls: 1, storage: 3)
                        [Balances] idx: 10 (calls: 6 -> 9, storage: 6 -> 8)
                                   [+] calls: transferAllowDeath, setBalanceDeprecated, upgradeAccounts, forceSetBalance
                                   [-] calls: setBalance
                                      [transfer] idx: 0 -> 7 (args: 2)
                                                 (MultiAddress, Compact<u128>)
                                   [+] storage: holds, freezes
                        [Treasury] idx: 12 (calls: 5, storage: 5)
               [CollatorSelection] idx: 21 (calls: 5 -> 7, storage: 6)
                                   [+] calls: addInvulnerable, removeInvulnerable
                         [Session] idx: 22 (calls: 2, storage: 8)
                         [Vesting] idx: 26 (calls: 5, storage: 3)
                           [Proxy] idx: 27 (calls: 10, storage: 3)
                        [Multisig] idx: 29 (calls: 4, storage: 2)
                       [XcmpQueue] idx: 30 (calls: 9, storage: 11)
                     [PolkadotXcm] idx: 31 (calls: 10 -> 11, storage: 12 -> 13)
                                   [+] calls: forceSuspension
                                   [+] storage: xcmExecutionSuspended
                        [DmpQueue] idx: 33 (calls: 1, storage: 6)
                         [Domains] idx: 60 (calls: 9, storage: 8)
                          [Energy] idx: 61 (calls: 2, storage: 4)
                       [FreeProxy] idx: 62 (calls: 1, storage: 2)
                  [CreatorStaking] idx: 63 (calls: 14, storage: 13)
                    [EvmAddresses] idx: 64 (calls: 2, storage: 3)
             [ResourceDiscussions] idx: 65 (calls: 2, storage: 2)
                           [Roles] idx: 71 (calls: 8, storage: 6)
                  [AccountFollows] idx: 72 (calls: 3, storage: 4)
                        [Profiles] idx: 73 (calls: 3, storage: 2)
                    [SpaceFollows] idx: 74 (calls: 3, storage: 4)
                       [Ownership] idx: 75 (calls: 3, storage: 2)
                          [Spaces] idx: 76 (calls: 4, storage: 4)
                     [PostFollows] idx: 77 (calls: 2, storage: 4)
                           [Posts] idx: 78 (calls: 6, storage: 6)
                       [Reactions] idx: 79 (calls: 6, storage: 5)
                            [Sudo] idx: 255 (calls: 4, storage: 2)

------------------------------ SUMMARY ------------------------------- 
⚠️ This filter is here to help spotting changes that should be reviewed carefully. 
⚠️ It catches only index changes, deletions and value decreases. 
## Deletions
 20: [-] calls: setBalance

## Index changes
 21: [transfer] idx: 0 -> 7 (args: 2)

## Decreases



----------------------------------------------------------------------

@F3Joule F3Joule merged commit 98f0b0a into main Dec 25, 2024
2 of 3 checks passed
@F3Joule F3Joule deleted the f3/upgrade-substrate branch January 6, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Add this label to PR that should run CI to build a new parachain docker image feature-release A new feature PR ready to release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants