Enable autoscaling by default #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-grieco
force-pushed
the
enable-autoscaling
branch
from
b9f89fc to
94fbd62
Compare
noyceb
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the elasticsearch configuration to enable autoscaling by default. However, there is a known issue where enabling autoscaling while defining a custom topology causes issues with the terraform provider. As such, autoscaling will only be enabled if both the autoscaling variable is set to true AND there is not a custom topology defined.
I have also removed the default topology since the deployment template will set a default topology which does work well with autoscaling.