Devops

[tsuberim]

• Generate abis from @daostack/arc automatically as part of codegen
• Allow configuration of the project to mainnet/development using yaml templating.
• Set up integration testing (unfortunately doesn't work right now due to bug in ganache)
• Development with or without docker & docker-compose.

[ben-kaufman]

I think the ABIs should be fixed to the live version of the protocol when choosing mainnet.

[orenyodfat]

redundant cr

[orenyodfat]

redundant cr

[orenyodfat]

@tsuberim which bug in ganache you are referring to ?

[tsuberim]

@orenyodfat The bug is trufflesuite/ganache#907 which has been fixed but not yet released as a new version.

[tsuberim]

@ben-kaufman just to be clear I only mean the ABI interface definitions (not the whole .json compiled file). Contract addresses are configured in ops/config.yaml. Since ABIs are the same regardless of the chain, I don't see what you mean.

[orenyodfat]

@orenyodfat The bug is trufflesuite/ganache#907 which has been fixed but not yet released as a new version.

Is that effect graph-node code or the code added for this pr ? Is there a way to bypass that ?
@tsuberim

[orenyodfat]

@ben-kaufman just to be clear I only mean the ABI interface definitions (not the whole .json compiled file). Contract addresses are configured in ops/config.yaml. Since ABIs are the same regardless of the chain, I don't see what you mean.

Please note that the deployment addresses can also potentially
be fetched out from the contract.json . (e.g arc.js package currently contain that though I guess it will be changed in the future ..need to discuss)
later on we can use this as part of the automate codegen (generate the yaml files)

[tsuberim]

@orenyodfat

1. It prevents us from running graph-node against ganache and thus running tests. I don't think there's a way to bypass it (maybe we should ask TheGraph team).
2. Yes, that's true.

[orenyodfat]

@tsuberim so it is basically a graph-node issue ? graphprotocol/graph-node#375 ?

[tsuberim]

@orenyodfat No, its ganache not following the spec (not setting the to field to null for contract creation tx)

[nenadjaja]

Hi @orenyodfat I updated the issue graphprotocol/graph-node#375 with the steps to run ganache locally (that works with graph-node). It has the fix, that's not released yet. Hope it helps!

[ben-kaufman]

@ben-kaufman just to be clear I only mean the ABI interface definitions (not the whole .json compiled file). Contract addresses are configured in ops/config.yaml. Since ABIs are the same regardless of the chain, I don't see what you mean.

I see that you import the ABI json files directly from Arc, while the version of the contract being used currently on the mainnet is different from the one in Arc, meaning the ABI is different than the ABI of the live contract.

[orenyodfat]

@ben-kaufman just to be clear I only mean the ABI interface definitions (not the whole .json compiled file). Contract addresses are configured in ops/config.yaml. Since ABIs are the same regardless of the chain, I don't see what you mean.

I see that you import the ABI json files directly from Arc, while the version of the contract being used currently on the mainnet is different from the one in Arc, meaning the ABI is different than the ABI of the live contract.

Right . we need to put some thoughts on how to handle multiple versions of the same contracts (with different abi or not)

[orenyodfat]

please add an .env template file

[orenyodfat]

I guess it will be nice to add ganache-cli to package.json and have a script to run it with the mnemonic

[tsuberim]

Setup API/Integration testing framework

[orenyodfat]

Should we add ganache-cli to package.json so it can be run manually regardless docker ?
please update readme on how to run development + tests

[orenyodfat]

👍
Lets merge this pr and open issues if needed.

[orenyodfat]

Add a link to graph-node GitHub as theGraph

[orenyodfat]

Maybe "DAOstack subgraph using graph-node project."