DAOS-2181 raft: Avoid passing raft_node_t pointers around #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing around pointers to raft_node_t objects and referencing them all over the code results in errors and crashes due to dangling pointers when nodes are removed. It is safer to use the node ID to look up a node from the server's node list. In the future, it would be ideal to introduce reference counting and thread safety to Raft as a whole and the node list in particular. Signed-off-by: Omkar Kulkarni <[email protected]>
liw
approved these changes
Mar 8, 2019
Code Review 001. Signed-off-by: Omkar Kulkarni <[email protected]>
liw
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing around pointers to raft_node_t objects and referencing them
all over the code results in errors and crashes due to dangling
pointers when nodes are removed. It is safer to use the node ID to
look up a node from the server's node list.
In the future, it would be ideal to introduce reference counting and
thread safety to Raft as a whole and the node list in particular.
Signed-off-by: Omkar Kulkarni [email protected]