Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16660 No error message on intentional pmemobj transaction abort #43

Merged
merged 10 commits into from
Jan 17, 2025
Merged

DAOS-16660 No error message on intentional pmemobj transaction abort #43

merged 10 commits into from
Jan 17, 2025

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Oct 4, 2024 •
edited
Loading

There are a few unnecessary warning messages generated by libpmemobj, which may cause misinterpretation of library behavior.

They are already disabled in the PMDK:
pmem/pmdk#6127
pmem/pmdk#6117

@grom72 grom72 force-pushed the grom72/DAOS-16660-no-error-msg-on-user-abort branch from 3b125fc to 0605844 Compare October 23, 2024 14:30
@grom72 grom72 mentioned this pull request Oct 24, 2024
Open
19 tasks
@grom72 grom72 force-pushed the grom72/DAOS-16660-no-error-msg-on-user-abort branch 4 times, most recently from 83592fc to 462db38 Compare November 5, 2024 12:20
@grom72
DAOS-16660 common: no-error-msg-on-user-abort
890f16d 
It also fixes:
DAOS-16758 - Unnecessary warning: "Cannot find any matching device,
				   no bad blocks found" for non-pmem HW

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260
Skip-list-release/2.6: test_daos_rebuild_ec:DAOS-16171 test_daos_rebuild_ec:DAOS-14982
Skip-list-master: test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Cancel-prev-build=false
Allow-unstable-test: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72 grom72 force-pushed the grom72/DAOS-16660-no-error-msg-on-user-abort branch from 462db38 to 890f16d Compare November 5, 2024 13:56
@grom72 grom72 marked this pull request as ready for review November 6, 2024 07:48
@grom72 grom72 requested a review from a team as a code owner November 6, 2024 07:48
janekmi
janekmi requested changes Nov 6, 2024
View reviewed changes
@grom72
Fix: documentation and release date update
c1a7150 
Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 CartRpcOneNodeSwimNotificationOnRankEvictionTest:DAOS-15989
Skip-list-release/2.6: test_daos_rebuild_ec:DAOS-16171 test_daos_rebuild_ec:DAOS-14982
Skip-list-master: test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Cancel-prev-build=false
Allow-unstable-test: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
janekmi
janekmi previously approved these changes Nov 6, 2024
View reviewed changes
@grom72
Fix: disable failing tests
d7ea15b 
Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 CartRpcOneNodeSwimNotificationOnRankEvictionTest:DAOS-15989 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Skip-list-release/2.6: test_daos_rebuild_ec:DAOS-16171 test_daos_rebuild_ec:DAOS-14982
Skip-list-master: test_daos_degraded_ec:DAOS-16503
Allow-unstable-test: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Copy link
Contributor Author

grom72 commented Nov 13, 2024

All tests have passed on:

@grom72 grom72 requested a review from a team November 13, 2024 06:54
@brianjmurrell
Copy link
Contributor

brianjmurrell commented Nov 18, 2024 •
edited
Loading

All tests have passed on:

Nice.

@grom72 Latest master test run failed in test_ior_intercept_libioil. Is that a known failure? If so, I will add it and it's ticket to the skiplist for landing so that maybe we get a green/passing landing.

@brianjmurrell
Copy link
Contributor

@grom72 Any thoughts on my previous question?

@grom72
Fix: update packaging
b9bbbc8 
Test-master-branch: grom72/pmdk-w-logging

skip NLT tests for full HW validation
Skip-NLT: true

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 CartRpcOneNodeSwimNotificationOnRankEvictionTest:DAOS-15989 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Skip-list-release/2.6: test_daos_rebuild_ec:DAOS-16171 test_daos_rebuild_ec:DAOS-14982
Skip-list-master: test_daos_degraded_ec:DAOS-16503

Allow-unstable-test: true
Priority: 2

Signed-off-by: Tomasz Gromadzki <[email protected]>
janekmi and others added 5 commits January 8, 2025 14:52
@janekmi
DAOS-16660 Trigger rebuild
e625038 
Test-master-branch: grom72/pmdk-w-logging

skip NLT tests for full HW validation
Skip-NLT: true

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 CartRpcOneNodeSwimNotificationOnRankEvictionTest:DAOS-15989 test_dfuse_daos_build_wt_pil4dfs:DAOS-16732
Skip-list-release/2.6: test_daos_rebuild_ec:DAOS-16171 test_daos_rebuild_ec:DAOS-14982
Skip-list-master: test_daos_degraded_ec:DAOS-16503 test_dfuse_daos_build_wt_il:SRE-471

Allow-unstable-test: true
Priority: 2

Signed-off-by: Jan Michalski <[email protected]>
@grom72
Fix: allow unstable tests of downstream build
132df66 
Test-master-branch: grom72/pmdk-w-logging

skip NLT tests for full HW validation
Skip-NLT: true

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 CartRpcOneNodeSwimNotificationOnRankEvictionTest:DAOS-15989
Skip-list-release/2.6: test_daos_rebuild_ec:DAOS-16171 test_daos_rebuild_ec:DAOS-14982
Skip-list-master: test_dfuse_daos_build_wt_il:SRE-471

Allow-unstable-test: true
Priority: 2

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Fix: allow unstable tests of downstream build
3113e0b 
Test-master-branch: grom72/pmdk-w-logging

Skip NLT tests for full HW validation
Skip-NLT: true

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 CartRpcOneNodeSwimNotificationOnRankEvictionTest:DAOS-15989
Skip-list-release/2.6: test_daos_rebuild_ec:DAOS-16171 test_daos_rebuild_ec:DAOS-14982
Skip-list-master: test_dfuse_daos_build_wt_il:SRE-471

Allow-unstable-test: true
Priority: 2

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Fix: allow unstable tests of downstream build
cf55039 
Test-master-branch: grom72/pmdk-w-logging

Skip NLT tests for full HW validation
Skip-NLT: true

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 CartRpcOneNodeSwimNotificationOnRankEvictionTest:DAOS-15989
Skip-list-release/2.6: test_daos_rebuild_ec:DAOS-16171 test_daos_rebuild_ec:DAOS-14982
Skip-list-master: test_dfuse_daos_build_wt_il:SRE-471

Allow-unstable-test: true
Priority: 2

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Fix: allow unstable tests of downstream build (3rd)
4dda74d 
Test-master-branch: grom72/pmdk-w-logging

skip NLT tests for full HW validation
Skip-NLT: true

Skip-list: test_ior_intercept_libpil4dfs:DAOS-16260 CartRpcOneNodeSwimNotificationOnRankEvictionTest:DAOS-15989
Skip-list-release/2.6: test_daos_rebuild_ec:DAOS-16171 test_daos_rebuild_ec:DAOS-14982
Skip-list-master: test_dfuse_daos_build_wt_il:SRE-471

Allow-unstable-test: true
Priority: 2

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72 grom72 mentioned this pull request Jan 14, 2025
Merged
@grom72 grom72 removed the request for review from a team January 14, 2025 16:27
@grom72
Revert "Fix: allow unstable tests of downstream build"
8d3e02e 
This reverts commit 132df66.

Doc-only: true

Signed-off-by: Tomasz Gromadzki <[email protected]>
@grom72
Copy link
Contributor Author

grom72 commented Jan 16, 2025 •
edited
Loading

All required tests pass:
https://build.hpdd.intel.com/job/daos-stack/job/pmdk/job/PR-43/19/pipeline-graph/ (https://build.hpdd.intel.com/job/daos-stack/job/daos/job/ci-daos-stack-pmdk-PR-43-master/36/pipeline-graph/)
master branch tests pass in an additional downstream run:
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/ci-daos-stack-pmdk-PR-43-master/37/pipeline-graph/

@grom72 grom72 requested review from a team and janekmi January 16, 2025 07:12
@grom72 grom72 merged commit 2f5846c into master Jan 17, 2025
2 checks passed
@grom72 grom72 deleted the grom72/DAOS-16660-no-error-msg-on-user-abort branch January 17, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjmurrell brianjmurrell brianjmurrell approved these changes

@janekmi janekmi janekmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grom72 @brianjmurrell @janekmi