update to 4.0.0 release #14
Conversation
daltonbohning
commented
Jan 12, 2024
•
daltonbohning
commented
- update to 4.0.0 release
- update packaging
Signed-off-by: Dalton Bohning <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
| URL: https://github.com/hpc/%{name}/ | ||
| Source0: https://github.com/hpc/%{name}/releases/download/%{version}/%{name}-%{version}.tar.gz | ||
| %if "%{?commit}" != "" | ||
| Patch1: %{version}..%{commit}.patch | ||
| %endif | ||
| Patch3: daos-configure.patch | ||
| # patch configure.ac | ||
| Patch3: https://github.com/hpc/ior/commit/38064419cbe959cb538695e51b2bc2a91d6971f7.patch |
There was a problem hiding this comment.
We could also just update to 4.0.0 + patch tip of main. Which is what the spec does currently. I.e. 3.3.0..d3574d536643475269d37211e283b49ebd6732d7.patch
There was a problem hiding this comment.
We could, at the risk of introducing post-4.0.0 landings that could be troublesome. I think what we are doing here is better and more idiomatic of software packaging.
|
|
||
| Summary: IOR-HPC | ||
|
|
||
| License: GPL | ||
| License: GPL-2.0-only |
There was a problem hiding this comment.
To resolve invalid-license lint
| %find_lang mdtest --with-man | ||
| %files -f files.mpich | ||
| %files -f mdtest.lang |
There was a problem hiding this comment.
Resolves file-not-in-%lang
|
@brianjmurrell Any advice on how to fix this lint warning for leap 15.5? I thought this was handled by Lines 61 to 62 in ecea31d |
I would think so too. As long at the ior build system was not overriding or ignoring those in some way. Does the build log show that they are being used? You might have to add a They in fact shouldn't even be necessary as hardened_build is default in EL > 7. Ahhh. But maybe necessary still for Leap. If so, we ought to guard that so that it doesn't override the goodness that RHEL bakes into their RPM build macros. |
For EL9, I see |
Signed-off-by: Dalton Bohning <[email protected]>
|
It looks like it's using it? Specifically, for the But lint complains |
|
Ah. Maybe it's |
|
It seems |
|
Looking at the EL9 log for the |
Signed-off-by: Dalton Bohning <[email protected]>
| export CFLAGS="$RPM_OPT_FLAGS -fno-strict-aliasing -fPIC -fPIE" | ||
| export CXXFLAGS="$RPM_OPT_FLAGS -fno-strict-aliasing -fPIC -fPIE" |
There was a problem hiding this comment.
Since EL >= 8 defaults to hardening their builds, we should gate these two lines on being SUSE only:
| export CFLAGS="$RPM_OPT_FLAGS -fno-strict-aliasing -fPIC -fPIE" | |
| export CXXFLAGS="$RPM_OPT_FLAGS -fno-strict-aliasing -fPIC -fPIE" | |
| %if (0%{?suse_version} >= 1500) | |
| export CFLAGS="$RPM_OPT_FLAGS -fno-strict-aliasing -fPIC -fPIE" | |
| export CXXFLAGS="$RPM_OPT_FLAGS -fno-strict-aliasing -fPIC -fPIE" | |
| %endif |
so that we don't interfere with EL doing the right thing on it's own.
| %endif | ||
|
|
||
| %changelog | ||
| * Fri Jan 12 2024 Dalton A. Bohning <[email protected]> - 4.0.0-1 |
There was a problem hiding this comment.
Let's do some datestamp updating here at some point since this is now 10 days ago.
|
These: are really odd given that we can see that the link (and all of the object compilations) are using the hardening flags: This is the link command from EL8: RH puts all of their hardening in which we can is some flavour of |
Signed-off-by: Dalton Bohning <[email protected]>
