DAOS-9599 chk: handle inconsistent pool label #9524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daosbuild1
reviewed
Jun 27, 2022
daosbuild1
reviewed
Jun 28, 2022
daosbuild1
reviewed
Jul 4, 2022
The pool label is mainly used by MS to lookup pool UUID by label. The PS recorded pool label is some kind of the backup. So if the MS known pool label does not match the pool label recorded by PS, then trust MS as long as MS known pool label is not NULL. Related repair will not happen on check leader, instead, it will be done on the PS leader during CHK__CHECK_SCAN_PHASE__CSP_POOL_CLEANUP. If the admin wants to recover pool label on MS with the pool info on PS, then it will use DRPC_METHOD_CHK_REG_POOL drpc upcall. The patch also contains some other fixes: 1. Only handle dangling pool within the given pools check list. 2. If some engine failed to report some pool information, then related pool cannot be handled as no quorum case. 3. Some code cleanup for "uint32_t" and "int32_t" usage in chk. Signed-off-by: Fan Yong <[email protected]>
daosbuild1
reviewed
Jul 6, 2022
Nasf-Fan
requested review from
mjmac and
liuxuezhao
and removed request for
a team
mjmac
reviewed
Jul 7, 2022
jolivier23
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pool label is mainly used by MS to lookup pool UUID by label.
The PS recorded pool label is some kind of the backup. So if the
MS known pool label does not match the pool label recorded by PS,
then trust MS as long as MS known pool label is not NULL. Related
repair will not happen on check leader, instead, it will be done
on the PS leader during CHK__CHECK_SCAN_PHASE__CSP_POOL_CLEANUP.
If the admin wants to recover pool label on MS with the pool info
on PS, then it will use DRPC_METHOD_CHK_REG_POOL drpc upcall.
The patch also contains some other fixes:
Only handle dangling pool within the given pools check list.
Some code cleanup for "uint32_t" and "int32_t" usage in chk.
Signed-off-by: Fan Yong [email protected]
Required-githooks: true