-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-10418 ddb: More program options #9210
DAOS-10418 ddb: More program options #9210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9210/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9210/1/execution/node/151/log |
cb446bc
to
17378f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9210/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules
Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9210/2/execution/node/133/log |
- Add -w option so commands that modify the tree can only be run in "write mode". - Add testing for -R option - Fix a bug where the pool wasn't being closed on program exit. - Add -f command to pass in a file with a list of commands - Restructure some of the ddb_main code for better reuse - Don't actually need to add "program_name" back in when running commands Signed-off-by: Ryon Jensen <[email protected]> Skip-func-test: true Signed-off-by: Ryon Jensen <[email protected]>
17378f3
to
1d3c9d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
Test stage Unit Test with memcheck completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9210/3/execution/node/780/log |
Test stage Unit Test completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9210/3/execution/node/808/log |
…jensen/DdbMoreOptions.DAOS-10418 Conflicts: src/ddb/ddb_main.c
Signed-off-by: Ryon Jensen <[email protected]> Skip-func-test: true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No errors found by checkpatch.
only be run in "write mode".
running commands
Signed-off-by: Ryon Jensen [email protected]