Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-10418 ddb: More program options #9210

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

ryon-jensen
Copy link
Contributor

  • Add -w option so commands that modify the tree can
    only be run in "write mode".
  • Add testing for -R option
  • Fix a bug where the pool wasn't being closed on program exit.
  • Add -f command to pass in a file with a list of commands
  • Restructure some of the ddb_main code for better reuse
  • Don't actually need to add "program_name" back in when
    running commands

Signed-off-by: Ryon Jensen [email protected]

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/ddb/ddb_main.c Show resolved Hide resolved
src/ddb/ddb_main.c Outdated Show resolved Hide resolved
src/ddb/ddb_main.c Outdated Show resolved Hide resolved
src/ddb/ddb_main.c Show resolved Hide resolved
src/ddb/ddb_main.c Outdated Show resolved Hide resolved
src/ddb/tests/ddb_main_tests.c Outdated Show resolved Hide resolved
src/ddb/tests/ddb_main_tests.c Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

@ryon-jensen ryon-jensen force-pushed the ryon-jensen/DdbMoreOptions.DAOS-10418 branch from cb446bc to 17378f3 Compare May 31, 2022 18:00
@daosbuild1 daosbuild1 dismissed their stale review May 31, 2022 18:02

Updated patch

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/ddb/ddb_main.c Show resolved Hide resolved
src/ddb/ddb_main.c Outdated Show resolved Hide resolved
src/ddb/ddb_main.c Outdated Show resolved Hide resolved
src/ddb/ddb_main.c Show resolved Hide resolved
src/ddb/ddb_main.c Outdated Show resolved Hide resolved
src/ddb/tests/ddb_main_tests.c Outdated Show resolved Hide resolved
src/ddb/tests/ddb_main_tests.c Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

- Add -w option so commands that modify the tree can
  only be run in "write mode".
- Add testing for -R option
- Fix a bug where the pool wasn't being closed on program exit.
- Add -f command to pass in a file with a list of commands
- Restructure some of the ddb_main code for better reuse
- Don't actually need to add "program_name" back in when
  running commands

Signed-off-by: Ryon Jensen <[email protected]>

Skip-func-test: true
Signed-off-by: Ryon Jensen <[email protected]>
@ryon-jensen ryon-jensen force-pushed the ryon-jensen/DdbMoreOptions.DAOS-10418 branch from 17378f3 to 1d3c9d5 Compare May 31, 2022 18:08
@daosbuild1 daosbuild1 dismissed their stale review May 31, 2022 18:11

Updated patch

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9210/3/execution/node/780/log

@daosbuild1
Copy link
Collaborator

src/ddb/ddb_commands.c Outdated Show resolved Hide resolved
src/ddb/ddb_entry.c Outdated Show resolved Hide resolved
src/ddb/ddb_main.c Show resolved Hide resolved
src/ddb/ddb_main.c Outdated Show resolved Hide resolved
src/ddb/ddb_entry.c Show resolved Hide resolved
…jensen/DdbMoreOptions.DAOS-10418

Conflicts:
	src/ddb/ddb_main.c
Signed-off-by: Ryon Jensen <[email protected]>

Skip-func-test: true
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

@mjmac mjmac merged commit 5cc4d48 into feature/cat_recovery Jun 7, 2022
@mjmac mjmac deleted the ryon-jensen/DdbMoreOptions.DAOS-10418 branch June 7, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants