Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-4350 Placement: Extended Placement Unit Test #2284

Merged
merged 10 commits into from
Apr 24, 2020
Merged

Conversation

PetFet
Copy link
Contributor

@PetFet PetFet commented Mar 31, 2020

Greatly extended unit tests to cover many different object
classes with placement, rebuild, and reintegration tests for
each object class.

Signed-off-by: Peter Fetros [email protected]

Stacked on this PR: #2256

PetFet added 3 commits March 31, 2020 22:44
Greatly extended unit tests to cover many different object
classes with placement, rebuild, and reintegration tests for
each object class.

Signed-off-by: Peter Fetros <[email protected]>
Signed-off-by: Peter Fetros <[email protected]>
@PetFet PetFet requested a review from byron-marohn March 31, 2020 23:05
@daosbuild1

This comment has been minimized.

@daosbuild1

This comment has been minimized.

@daosbuild1

This comment has been minimized.

@daosbuild1

This comment has been minimized.

@daosbuild1

This comment has been minimized.

@daosbuild1
Copy link
Collaborator

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-2284/4/execution/node/68/log

@daosbuild1
Copy link
Collaborator

@PetFet PetFet requested review from gnailzenh, NiuYawei and wangdi1 April 6, 2020 23:27
@daosbuild1
Copy link
Collaborator

Test stage Functional_Hardware_Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-2284/4/testReport/(root)/

Removed the code that skipped over the erasure coded objects.
They seem to work, but need at least 18 ranks for the largest one.

Signed-off-by: Peter Fetros <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-2284/5/execution/node/68/log

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int
main(int argc, char **argv)
{
// struct daos_oclass_attr *obj_attr;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) do not use C99 // comments

@daosbuild1
Copy link
Collaborator

@daosbuild1
Copy link
Collaborator

@daosbuild1
Copy link
Collaborator

Test stage Functional_Hardware_Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-2284/5/testReport/(root)/

wangdi1
wangdi1 previously approved these changes Apr 8, 2020
Copy link
Contributor

@wangdi1 wangdi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw: we probably need a unit test case to measure if the jch is balanced enough. for example,

  1. create 100k object, to see if objects are evenly distributed among all pool targets.
  2. create a OSX object, then insert 100k dkey, to see if the dkey is even distributed among all shards.

@daosbuild1
Copy link
Collaborator

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-2284/6/execution/node/68/log

@daosbuild1 daosbuild1 dismissed their stale review April 8, 2020 20:59

Updated patch

Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int
main(int argc, char **argv)
{
// struct daos_oclass_attr *obj_attr;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(style) do not use C99 // comments

@daosbuild1
Copy link
Collaborator

@daosbuild1
Copy link
Collaborator

Test stage Python Bandit check completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-2284/7/execution/node/69/log

@daosbuild1 daosbuild1 dismissed their stale review April 8, 2020 22:07

Updated patch

@daosbuild1
Copy link
Collaborator

@daosbuild1
Copy link
Collaborator

Test stage Functional_Hardware_Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-2284/7/testReport/(root)/

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on CentOS 7 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-2284/9/execution/node/209/log

@skirvan44 skirvan44 requested a review from shimizukko April 20, 2020 23:26
Copy link
Contributor

@shimizukko shimizukko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@daosbuild1
Copy link
Collaborator

@PetFet PetFet requested a review from a team April 23, 2020 22:03
@johannlombardi johannlombardi merged commit 8130cc8 into master Apr 24, 2020
@johannlombardi johannlombardi deleted the DAOS-4350 branch April 24, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants