Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16263 cq: merge yamllint and clang-format into linting (#14803) #15642

Merged
merged 1 commit into from
Dec 20, 2024
Merged

DAOS-16263 cq: merge yamllint and clang-format into linting (#14803) #15642

merged 1 commit into from
Dec 20, 2024

Conversation

daltonbohning
Copy link
Contributor

merge yamllint and clang-format into linting workflow so all lint checks are grouped together.

Make yaml-lint required but clang-format optional until stable.

Skip-build: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning
DAOS-16263 cq: merge yamllint and clang-format into linting (#14803)
868206b 
merge yamllint and clang-format into linting workflow so all lint checks
are grouped together.

Make yaml-lint required but clang-format optional until stable.

Skip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning added unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. release-2.6.3 Targeted for 2.6.3 labels Dec 18, 2024
@daltonbohning daltonbohning added this to the Release 2.6.3 milestone Dec 18, 2024
@daltonbohning daltonbohning self-assigned this Dec 18, 2024
@github-actions GitHub Actions
Copy link

Ticket title is 'gha: merge clang-format and yaml lint into Linting workflow'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16263

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 18, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 18, 2024
View reviewed changes
.github/workflows/linting.yml
python-version: '3'
- name: Install extra python packages
run: python3 -m pip install --requirement utils/cq/requirements.txt
- name: Run check

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 1: pipCommand not pinned by hash
Click Remediation section below to solve this issue
@daltonbohning daltonbohning marked this pull request as ready for review December 18, 2024 22:53
@daltonbohning daltonbohning requested a review from a team December 20, 2024 17:12
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Dec 20, 2024
@daltonbohning daltonbohning merged commit 1aeb63e into release/2.6 Dec 20, 2024
40 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16263-2.6 branch December 20, 2024 17:12
@juszhan1 juszhan1 mentioned this pull request Dec 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@grom72 grom72 Awaiting requested review from grom72

@janekmi janekmi Awaiting requested review from janekmi

@jolivier23 jolivier23 Awaiting requested review from jolivier23

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed) release-2.6.3 Targeted for 2.6.3 unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Milestone
Release 2.6.3
Development

Successfully merging this pull request may close these issues.
2 participants
@daltonbohning @phender