DAOS-16829 client: Fix daos pool query regression #15638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch landed for DAOS-16477 introduced a regression in the pool query functionality of the daos tool. This patch simplifies the pool query logic to retrieve enabled and disabled ranks. Dead ranks are not available to the client without pool query protocol changes. Features: daos_cmd Required-githooks: true Signed-off-by: Michael MacDonald <[email protected]>
|
Ticket title is 'Regression with pool/query_attribute.py functional test' |
tanabarr
reviewed
Dec 18, 2024
Update query bits for enabled engines query. Features: daos_cmd Required-githooks: true Signed-off-by: Michael MacDonald <[email protected]>
wangshilong
approved these changes
Dec 19, 2024
tanabarr
requested changes
Dec 19, 2024
There is a functional test, which is currently failing on master and will continue to fail until this lands. Writing unit tests for cgo calls in the daos tool is close to impossible with the current code organization. |
tanabarr
approved these changes
Dec 19, 2024
knard38
reviewed
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch landed for DAOS-16477 introduced a regression
in the pool query functionality of the daos tool. This
patch simplifies the pool query logic to retrieve
enabled and disabled ranks. Dead ranks are not available
to the client without pool query protocol changes.
Features: daos_cmd
Required-githooks: true
Signed-off-by: Michael MacDonald [email protected]