-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16887 dfuse: use the inode instead of open handle in pre-read #15630
Conversation
Ticket title is 'dfuse/daos_build.py:DaosBuild.test_dfuse_daos_build_wt_il - Transport endpoint is not connected: '.sconsign.tmp'' |
Features: dfuse Skip-func-test-el9: false Skip-func-test-leap15: false Required-githooks: true Signed-off-by: Mohamad Chaarawi <[email protected]>
e890447
to
c23882b
Compare
Test stage Unit Test on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15630/4/display/redirect |
@@ -642,6 +642,6 @@ dfuse_pre_read(struct dfuse_info *dfuse_info, struct dfuse_obj_hdl *oh) | |||
d_slab_release(eqt->de_pre_read_slab, ev); | |||
active->readahead->dra_ev = NULL; | |||
} | |||
active_ie_decref(dfuse_info, oh->doh_ie); | |||
active_ie_decref(dfuse_info, ie); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code holds a reference on the inode being "active" which itself holds a reference on the inode so it should be safe to access ie
here.
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15630/6/testReport/ |
The NLT failure is in the go runtime and unrelated to this:
|
The file open handle can be freed from under the pre-read. The inode should be used instead.
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: