Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16887 dfuse: use the inode instead of open handle in pre-read #15630

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

mchaarawi
Copy link
Contributor

@mchaarawi mchaarawi commented Dec 17, 2024

The file open handle can be freed from under the pre-read. The inode should be used instead.

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Sorry, something went wrong.

Copy link

Ticket title is 'dfuse/daos_build.py:DaosBuild.test_dfuse_daos_build_wt_il - Transport endpoint is not connected: '.sconsign.tmp''
Status is 'Open'
Labels: 'ci_master_weekly,weekly_test'
https://daosio.atlassian.net/browse/DAOS-16887

Features: dfuse
Skip-func-test-el9: false
Skip-func-test-leap15: false
Required-githooks: true

Signed-off-by: Mohamad Chaarawi <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Unit Test on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15630/4/display/redirect

@mchaarawi mchaarawi changed the title DAOS-16887 dfuse: test build with il DAOS-16887 dfuse: use the inode instead of open handle in pre-read Dec 17, 2024
@@ -642,6 +642,6 @@ dfuse_pre_read(struct dfuse_info *dfuse_info, struct dfuse_obj_hdl *oh)
d_slab_release(eqt->de_pre_read_slab, ev);
active->readahead->dra_ev = NULL;
}
active_ie_decref(dfuse_info, oh->doh_ie);
active_ie_decref(dfuse_info, ie);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code holds a reference on the inode being "active" which itself holds a reference on the inode so it should be safe to access ie here.

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15630/6/testReport/

@mchaarawi
Copy link
Contributor Author

The NLT failure is in the go runtime and unrelated to this:

<error>
  <unique>0x103</unique>
  <tid>4</tid>
  <kind>InvalidRead</kind>
  <what>Invalid read of size 8</what>
  <stack>
    <frame>
      <ip>0xD08EB7</ip>
      <obj>/opt/daos/bin/daos</obj>
      <fn>__tsan_go_atomic64_fetch_add</fn>
    </frame>
    <frame>
      <ip>0x49B579</ip>
      <obj>/opt/daos/bin/daos</obj>
      <fn>racecall</fn>
      <dir>/usr/lib/golang/src/runtime</dir>
      <file>race_amd64.s</file>
      <line>396</line>
    </frame>
  </stack>
  <auxwhat>Address 0xc0003c4700 is in a rw- anonymous segment</auxwhat>
  <suppression>
    <sname>insert_a_suppression_name_here</sname>
    <skind>Memcheck:Addr8</skind>
    <sframe> <fun>__tsan_go_atomic64_fetch_add</fun> </sframe>
    <sframe> <fun>racecall</fun> </sframe>
    <rawtext>

@mchaarawi mchaarawi marked this pull request as ready for review December 18, 2024 20:52
@mchaarawi mchaarawi requested review from a team as code owners December 18, 2024 20:52
@mchaarawi mchaarawi requested a review from a team December 18, 2024 20:53
@mchaarawi mchaarawi added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Dec 18, 2024
@mchaarawi mchaarawi merged commit f4f53ee into master Dec 18, 2024
59 of 61 checks passed
@mchaarawi mchaarawi deleted the mschaara/16887 branch December 18, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

None yet

5 participants