Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16262 ci: Force Bullseye workflow to run #15628

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DAOS-16262 ci: Force Bullseye workflow to run #15628

wants to merge 1 commit into from

Conversation

brianjmurrell
Copy link
Contributor

Since it runs on a schedule there will be no Run-GHA commit pragma to force it to run so set the input to force it.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
    • Skipping build and test since this is for GHA and only affects a scheduled run.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@brianjmurrell
DAOS-16262 ci: Force Bullseye workflow to run
d176abf 
Since it runs on a schedule there will be no Run-GHA commit pragma to
force it to run so set the input to force it.

Skip-PR-comments: true
Skip-build: true

Signed-off-by: Brian J. Murrell <[email protected]>
@brianjmurrell brianjmurrell self-assigned this Dec 17, 2024
@github-actions GitHub Actions
Copy link

Ticket title is 'Automate weekly build with Bullseye with simple VM functional test'
Status is 'Resolved'
https://daosio.atlassian.net/browse/DAOS-16262

@brianjmurrell brianjmurrell marked this pull request as ready for review December 17, 2024 15:52
@brianjmurrell brianjmurrell requested a review from a team as a code owner December 17, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

Assignees

@brianjmurrell brianjmurrell

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianjmurrell @daltonbohning @phender