Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16886 control: Update deprecated code #15624

Merged
merged 2 commits into from
Dec 19, 2024
Merged

DAOS-16886 control: Update deprecated code #15624

merged 2 commits into from
Dec 19, 2024

Conversation

mjmac
Copy link
Contributor

@mjmac mjmac commented Dec 16, 2024

The ioutil package has been deprecated since Go 1.16
and may be removed in the future. Update the code to
use the standard interfaces.

Also fix a linter warning that is now a compile error
in Go 1.24+ (non-constant format string in call
to *f functions).

Features: control
Required-githooks: true
Signed-off-by: Michael MacDonald [email protected]

The ioutil package has been deprecated since Go 1.16
and may be removed in the future. Update the code to
use the standard interfaces.

Also fix a linter warning that is now a compile error
in Go 1.24+ (non-constant format string in call
to *f functions).

Features: control
Required-githooks: true
Signed-off-by: Michael MacDonald <[email protected]>
@mjmac mjmac requested review from a team as code owners December 16, 2024 21:36
Copy link

Ticket title is 'Update control plane code for Go 1.24+'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-16886

Copy link
Contributor

@kjacque kjacque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks.

@mjmac mjmac requested a review from tanabarr December 18, 2024 19:19
@mjmac mjmac merged commit 41a05cf into master Dec 19, 2024
57 checks passed
@mjmac mjmac deleted the mjmac/DAOS-16886 branch December 19, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants