Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16874 tests: Update expected pool_layout_ver #15610

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

liw
Copy link
Contributor

@liw liw commented Dec 13, 2024

Update expected pool_layout_ver in
dmg_pool_query_test/test_pool_query_basic.

Test-tag: test_pool_query_basic

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Update expected pool_layout_ver in
dmg_pool_query_test/test_pool_query_basic.

Test-tag: test_pool_query_basic
Signed-off-by: Li Wei <[email protected]>
Required-githooks: true
Copy link

Ticket title is 'control/dmg_pool_query_test.py:DmgPoolQueryTest.test_pool_query_basic - different pool_layout_ver and upgrade_layout_ver than expected'
Status is 'Open'
Labels: 'ci_master_daily,daily_test'
https://daosio.atlassian.net/browse/DAOS-16874

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15610/1/testReport/

liw added 2 commits December 16, 2024 09:16
Signed-off-by: Li Wei <[email protected]>
Required-githooks: true
Test-tag: test_pool_query_basic
Required-githooks: true
@liw liw force-pushed the liw/pool-query-test branch from c22c27e to 4db97f0 Compare December 16, 2024 00:18
@liw
Copy link
Contributor Author

liw commented Dec 16, 2024

Modified the commit message of the merge commit to add test-tag.

@phender
Copy link
Contributor

phender commented Dec 16, 2024

Testing looks good: https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15610/3/testReport/FTEST_control/DmgPoolQueryTest/. It will require a forced landing due to only needing to run the one functional test.

@phender phender marked this pull request as ready for review December 16, 2024 17:14
@phender phender requested review from a team as code owners December 16, 2024 17:14
@phender phender requested a review from a team December 16, 2024 17:14
@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Dec 16, 2024
@phender phender merged commit a614b38 into master Dec 16, 2024
54 checks passed
@phender phender deleted the liw/pool-query-test branch December 16, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

4 participants