Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport patches for supporting suspect rank query #15602

Closed
wants to merge 3 commits into from
Closed

Backport patches for supporting suspect rank query #15602

wants to merge 3 commits into from

Conversation

jolivier23
Copy link
Contributor

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

jolivier23 and others added 3 commits December 11, 2024 14:10
@jolivier23
Partial backport of debug macro patch
b3041bd 
Required-githooks: true

Change-Id: Ifd3f793661ea9f64aa47162a791b17b4987164ba
Signed-off-by: Jeff Olivier <[email protected]>
@liuxuezhao @jolivier23
DAOS-16702 rebuild: restart rebuild for a massive failure case (#15343)
f945f17 
* DAOS-16702 rebuild: restart rebuild for a massive failure case

In special massive failure case -
1. some engines down and triggered rebuild.
2. one engine participated the rebuild, not finished yet, it down again,
   the #failures exceeds pool RF and will not change pool map.
3. That engine restarted by administrator.

In that case should recover the rebuild task on the engine, to simplify it now just
abort and retry the global rebuild task.
No such issue by the typical recover approach that restart the whole
system including the PS leader.

Signed-off-by: Xuezhao Liu <[email protected]>
@wangshilong @phender @jolivier23
DAOS-16477 mgmt: return suspect engines for pool healthy query (#15458)
6def09b 
* DAOS-16477 mgmt: return suspect engines for pool healthy query

After significant failures, the system may leave behind some suspect
engines that were marked as DEAD by the SWIM protocol, but were not
excluded from the system to prevent data loss. An administrator
can bring these ranks back online by restarting them.

This PR aims to provide an administrative interface for querying
suspect engines following a massive failure. These suspect engines
can be retrieved using the daos/dmg --health-only command.

An example of output of dmg pool query --health-only:

Pool 6f450a68-8c7d-4da9-8900-02691650f6a2, ntarget=8, disabled=2, leader=3, version=4, state=Degraded
Pool health info:
- Disabled ranks: 1
- Suspect ranks: 2
- Rebuild busy, 0 objs, 0 recs

Features: DmgPoolQueryRanks
Signed-off-by: Wang Shilong <[email protected]>
Signed-off-by: Phil Henderson <[email protected]>
Co-authored-by: Phil Henderson <[email protected]>
@github-actions GitHub Actions
Copy link

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Backport

@jolivier23 jolivier23 requested a review from wangdi1 December 12, 2024 00:32
@jolivier23 jolivier23 requested a review from mjmac December 12, 2024 01:38
@jolivier23 jolivier23 closed this Dec 13, 2024
@jolivier23 jolivier23 deleted the jvolivie/try_again_patch branch December 13, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangdi1 wangdi1 wangdi1 approved these changes

@mjmac mjmac Awaiting requested review from mjmac

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jolivier23 @wangdi1 @liuxuezhao @wangshilong