DAOS-16872 cq: Bump isort/isort-action from 1.1.0 to 1.1.1 #15594

dependabot · 2024-12-11T16:00:26Z

Bumps isort/isort-action from 1.1.0 to 1.1.1.

Release notes

Sourced from isort/isort-action's releases.

v1.1.1

See CHANGELOG for details.

Changelog

Sourced from isort/isort-action's changelog.

Changelog

All notable changes to this project will be documented in this file.

The format is based on Keep a Changelog, and this project adheres to Semantic Versioning.

[Unreleased]

[1.1.1] - 2024-10-14

Added

A problem matcher so you can see issues without trawling through logs

Changed

Update plugin to be POSIX-compliant to support usage on MacOS runners

Fixed

Packages are installed into a virtualenv due to the fact that system-wide installs fail by default when run on newer versions of Python.

Print stderr to console when action fails.

[1.1.0] - 2022-11-04

All inputs changed to use kebab-case: isort-version, sort-paths, and requirements-files. The old camelCase arguments will continue to work for backward compatibility.

[Internal] Usage of set-output updated to reflect deprecation

[1.0.0] - 2022-06-01

Added

Contributing guide

Continuous Integration test suite

Changed

Default to using the latest version of isort, if the isortVersion input is not specified

Include pip install output in the log outputs instead of suppressing it.

Fixed

Configuration parameter parsing in run_isort

Only attempt to pip install from a requirements file if listed in the configuration

[0.1.0] - 2020-10-04

... (truncated)

Commits

24d8a7a Release v1.1.1 (#100)
e6ee1f2 Capture both stdout and stderr of isort command (#99)
314ebe9 Support running on MacOS Runners (#98)
abb0df9 Update versions (#97)
3e10211 Install packages in a virtualenv (#96)
f5c0654 Bump mvdan/shfmt from v3.8.0 to v3.9.0 in /.github/linting (#92)
652dde0 Update docker compose command (#93)
e2c21ac Bump koalaman/shellcheck from v0.9.0 to v0.10.0 in /.github/linting (#89)
5cb63b9 Bump yamllint from 1.35.0 to 1.35.1 in /.github/linting (#88)
5a0af1d Bump yamllint from 1.34.0 to 1.35.0 in /.github/linting (#87)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [isort/isort-action](https://github.com/isort/isort-action) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/isort/isort-action/releases) - [Changelog](https://github.com/isort/isort-action/blob/master/CHANGELOG.md) - [Commits](isort/isort-action@f14e57e...24d8a7a) --- updated-dependencies: - dependency-name: isort/isort-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

daltonbohning · 2024-12-11T16:22:28Z

Stopped Jenkins CI since this only modifies GHA

github-actions · 2024-12-11T16:33:38Z

Ticket title is 'Dependabot GHA updates 2024-12-11'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16872

Skip-build: true Required-githooks: true Signed-off-by: Dalton Bohning <[email protected]>

brianjmurrell · 2024-12-16T15:17:43Z

.github/workflows/linting.yml

+      - name: Checkout code
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11  # v4.1.1
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+      - name: Set up Python environment
+        uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d  # v5.1.0
+        with:
+          python-version: '3'


Aren't these duplicating these lines below:

daos/.github/workflows/linting.yml

Lines 33 to 38 in e7ad8cb

- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

with:

ref: ${{ github.event.pull_request.head.sha }}

- uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0

with:

python-version: '3'

Yep :( Looks like I did a "copy" instead of "cut"

Fixed. Thanks

Skip-build: true Required-githooks: true Signed-off-by: Dalton Bohning <[email protected]>

daltonbohning · 2024-12-16T17:22:09Z

.github/workflows/linting.yml

-      - uses: isort/isort-action@f14e57e1d457956c45a19c05a89cccdf087846e5  # v1.1.0
+      - name: Install extra python packages
+        run: python3 -m pip install --requirement utils/cq/requirements.txt
+      - name: Run isort


I'm not sure what this one is upset about. Maybe because it's python3 instead of 3.x?

Ugh. They want us to use pip install --require-hashes, and then pin every SHA in the requirements file. Which e.g. would look like

flake8==7.1.1 --hash=sha256:597477df7860daa5aa0fdd84bf5208a043ab96b8e96ab708770ae0364dd03213

I think better to handle that separately since it's not just isort

Created https://daosio.atlassian.net/browse/DAOS-16904

- Bump github/codeql-action from 3.24.9 to 3.27.7 (#15589) - Bump github/codeql-action from 3.27.7 to 3.27.9 (#15618) - Bump thollander/actions-comment-pull-request from 2 to 3 (#15590) - Bump aquasecurity/trivy-action from 0.28.0 to 0.29.0 (#15591) - Bump codespell-project/actions-codespell to latest (#15592) - Bump EnricoMi/publish-unit-test-result-action from 1.17 to 2.7 (#15593) - Bump isort/isort-action from 1.1.0 to 1.1.1 (#15594) - Bump phoenix-actions/test-reporting from 10 to 15 (#15617) Skip-build: true Required-githooks: true Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Dalton Bohning <[email protected]> Signed-off-by: Brian J. Murrell <[email protected]> Signed-off-by: Dalton Bohning <[email protected]>

- Bump github/codeql-action from 3.24.9 to 3.27.7 (#15589) - Bump github/codeql-action from 3.27.7 to 3.27.9 (#15618) - Bump github/codeql-action from 3.27.9 to 3.28.0 (#15662) - Bump thollander/actions-comment-pull-request from 2 to 3 (#15590) - Bump aquasecurity/trivy-action from 0.28.0 to 0.29.0 (#15591) - Bump codespell-project/actions-codespell to latest (#15592) - Bump EnricoMi/publish-unit-test-result-action from 1.17 to 2.7 (#15593) - Bump EnricoMi/publish-unit-test-result-action from 2.7.0 to 2.18.0 (#15660) - Bump isort/isort-action from 1.1.0 to 1.1.1 (#15594) - Bump phoenix-actions/test-reporting from 10 to 15 (#15617) - Bump actions/setup-python from 5.1.0 to 5.3.0 (#15661) Run-GHA: true Test-tag: always_passes Required-githooks: true Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Dalton Bohning <[email protected]>

- Bump github/codeql-action from 3.24.9 to 3.27.7 (#15589) - Bump github/codeql-action from 3.27.7 to 3.27.9 (#15618) - Bump github/codeql-action from 3.27.9 to 3.28.0 (#15662) - Bump thollander/actions-comment-pull-request from 2 to 3 (#15590) - Bump aquasecurity/trivy-action from 0.28.0 to 0.29.0 (#15591) - Bump codespell-project/actions-codespell to latest (#15592) - Bump EnricoMi/publish-unit-test-result-action from 1.17 to 2.7 (#15593) - Bump EnricoMi/publish-unit-test-result-action from 2.7.0 to 2.18.0 (#15660) - Bump isort/isort-action from 1.1.0 to 1.1.1 (#15594) - Bump phoenix-actions/test-reporting from 10 to 15 (#15617) - Bump actions/setup-python from 5.1.0 to 5.3.0 (#15661) Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Dalton Bohning <[email protected]>

dependabot bot requested a review from a team as a code owner December 11, 2024 16:00

dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Dec 11, 2024

setup python for isort

ca34d9e

Skip-build: true Required-githooks: true Signed-off-by: Dalton Bohning <[email protected]>

daltonbohning self-assigned this Dec 11, 2024

daltonbohning changed the title ~~Build(deps): Bump isort/isort-action from 1.1.0 to 1.1.1~~ DAOS-16872 cq: Bump isort/isort-action from 1.1.0 to 1.1.1 Dec 11, 2024

checkout before setup pythong

e7ad8cb

Skip-build: true Required-githooks: true Signed-off-by: Dalton Bohning <[email protected]>

daltonbohning marked this pull request as draft December 11, 2024 17:09

daltonbohning marked this pull request as ready for review December 11, 2024 17:37

daltonbohning requested review from brianjmurrell and phender December 11, 2024 17:37

phender previously approved these changes Dec 11, 2024

View reviewed changes

daltonbohning requested review from grom72 and ryon-jensen December 12, 2024 16:53

brianjmurrell reviewed Dec 16, 2024

View reviewed changes

fix duplicate code

2b59c17

Skip-build: true Required-githooks: true Signed-off-by: Dalton Bohning <[email protected]>

daltonbohning dismissed phender’s stale review via 2b59c17 December 16, 2024 15:27

github-advanced-security bot found potential problems Dec 16, 2024

View reviewed changes

daltonbohning requested review from phender and brianjmurrell December 16, 2024 22:22

brianjmurrell approved these changes Dec 17, 2024

View reviewed changes

daltonbohning requested a review from janekmi December 18, 2024 14:57

phender approved these changes Dec 20, 2024

View reviewed changes

daltonbohning requested a review from a team December 20, 2024 17:00

daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Dec 20, 2024

daltonbohning merged commit 21c51ed into master Dec 20, 2024
40 checks passed

daltonbohning deleted the dependabot/github_actions/isort/isort-action-1.1.1 branch December 20, 2024 17:01

daltonbohning mentioned this pull request Jan 7, 2025

DAOS-16872 cq: Bump GHA versions #15693

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAOS-16872 cq: Bump isort/isort-action from 1.1.0 to 1.1.1 #15594

DAOS-16872 cq: Bump isort/isort-action from 1.1.0 to 1.1.1 #15594

dependabot bot commented on behalf of github Dec 11, 2024

daltonbohning commented Dec 11, 2024

github-actions bot commented Dec 11, 2024 •

edited

Loading

brianjmurrell Dec 16, 2024

daltonbohning Dec 16, 2024

daltonbohning Dec 16, 2024

daltonbohning Dec 16, 2024

daltonbohning Dec 16, 2024

daltonbohning Dec 20, 2024

	- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
	with:
	ref: ${{ github.event.pull_request.head.sha }}
	- uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
	with:
	python-version: '3'

DAOS-16872 cq: Bump isort/isort-action from 1.1.0 to 1.1.1 #15594

DAOS-16872 cq: Bump isort/isort-action from 1.1.0 to 1.1.1 #15594

Conversation

dependabot bot commented on behalf of github Dec 11, 2024

v1.1.1

Changelog

[Unreleased]

[1.1.1] - 2024-10-14

Added

Changed

Fixed

[1.1.0] - 2022-11-04

[1.0.0] - 2022-06-01

Added

Changed

Fixed

[0.1.0] - 2020-10-04

daltonbohning commented Dec 11, 2024

github-actions bot commented Dec 11, 2024 • edited Loading

brianjmurrell Dec 16, 2024

Choose a reason for hiding this comment

daltonbohning Dec 16, 2024

Choose a reason for hiding this comment

daltonbohning Dec 16, 2024

Choose a reason for hiding this comment

daltonbohning Dec 16, 2024

Choose a reason for hiding this comment

daltonbohning Dec 16, 2024

Choose a reason for hiding this comment

daltonbohning Dec 20, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 11, 2024 •

edited

Loading