Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16170 cart: refine corpc fail handling for CRT_RPC_FLAG_CO_FAILOUT #15572

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

liuxuezhao
Copy link
Contributor

reset rc to 0 to avoid unnecessary RPC_DECREF in fail case in crt_req_send.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@liuxuezhao liuxuezhao requested review from a team as code owners December 7, 2024 08:36
Copy link

github-actions bot commented Dec 7, 2024

Ticket title is 'recovery/cat_recov_core.py:CatRecovCoreTest.test_daos_cat_recov_core - server was not found in its expected state - 17 TEST(S) FAILED'
Status is 'Awaiting backport'
Labels: 'ci_2.6_daily,ci_master_daily,daily_test,request_for_2.6.3'
https://daosio.atlassian.net/browse/DAOS-16170

@liuxuezhao
Copy link
Contributor Author

@Nasf-Fan could you please test if this can also fix the CR test failure at convenient time? thx

frostedcmos
frostedcmos previously approved these changes Dec 7, 2024
Copy link
Contributor

@frostedcmos frostedcmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for addressing this ref count issue the proper way:)

Nasf-Fan
Nasf-Fan previously approved these changes Dec 11, 2024
src/cart/crt_corpc.c Show resolved Hide resolved
reset rc to 0 to avoid unnecessary RPC_DECREF in fail case in
crt_req_send.

Required-githooks: true

Signed-off-by: Xuezhao Liu <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15572/8/testReport/

@liuxuezhao liuxuezhao requested a review from a team December 16, 2024 09:35
@daltonbohning daltonbohning merged commit c86aa7b into master Dec 16, 2024
51 of 52 checks passed
@daltonbohning daltonbohning deleted the lxz/corpc_ref branch December 16, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants