DAOS-16500 build: Move to Leap 15.6 #15561

phender · 2024-12-04T16:55:16Z

Build and test with Leap 15.6 instead of Leap 15.5.

Skip-func-hw-test: true
Skip-func-test-leap15: false

Required-githooks: true

Before requesting gatekeeper:

Two review approvals and any prior change requests have been resolved.
Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
Commit messages follows the guidelines outlined here.
Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

Build and test with Leap 15.6 instead of Leap 15.5. Skip-func-hw-test: true Skip-func-test-leap15: false Required-githooks: true Signed-off-by: Phil Henderson <[email protected]>

daosbuild1 · 2024-12-04T16:59:56Z

Test stage Build RPM on Leap 15.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/1/execution/node/347/log

daosbuild1 · 2024-12-04T17:06:05Z

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/1/execution/node/350/log

daosbuild1 · 2024-12-04T17:10:05Z

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/1/execution/node/384/log

github-actions · 2024-12-04T17:15:52Z

Ticket title is 'DAOS 2.6.2 SLES 15 SP6 support'
Status is 'In Review'
Labels: 'lrz,testp1'
https://daosio.atlassian.net/browse/DAOS-16500

daosbuild1 · 2024-12-04T17:18:49Z

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/1/execution/node/273/log

daosbuild1 · 2024-12-04T17:24:30Z

Test stage Build on Leap 15.6 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/1/execution/node/524/log

Jenkinsfile

ci/parse_ci_envs.sh

utils/rpms/packaging/Makefile_distro_vars.mk

Skip-func-hw-test: true Skip-func-test-leap15: false Required-githooks: true Signed-off-by: Phil Henderson <[email protected]>

brianjmurrell · 2024-12-10T14:06:38Z

Jenkinsfile

@@ -1081,7 +1082,7 @@ pipeline {
                            rpm_test_post(env.STAGE_NAME, env.NODELIST)
                        }
                    }
-                } // stage('Test CentOS 7 RPMs')
+                } // stage('Test RPMs on EL 8.6')
                stage('Test RPMs on Leap 15.4') {


Do you still want to be testing on Leap 15.4 here, or should this be 15.5 with this move to 15.6?

If the goal here is to run this test on the N-1 version, then I should. Is that the intention of this stage?

Generally yes-ish. The ultimate goal is to run this stage on any other version of a distro that is supported for a release. Generally that is only n-1 if even that. For Leap, I think we tend to be less willing to support n and n-1 but for EL, we do tend to be more willing to do that.

Which versions we support in a release is supposed to be tracked in SRS tickets such as this one for the 2.8 Community Release. That ticket unfortunately seems to be incomplete at this time.

The SRS ticket for the 2.6 Community Release though is a more complete example. You can see that it only specifies Leap 15.5. That would/should be why that stage is generally skipped such as you can see here. That should be driven by the value of the CI_RPMS_leap15.4_TEST parameter in the Jenkinsfile but I see that that parameter is actually currently missing.

Similarly, the Test RPMs on EL 8.6 stage (it should actually be 8.8 with main functional testing on 8.10 -- clearly things have slipped in that regard) is being run because SRS-407 says we are covering two releases for EL8.

I am at a loss however to explain why that Test RPMs on EL 8.6 stage is being run as the Jenkinsfile is also missing the CI_RPMS_el8.6_TEST that the stage skip code for that stage wants: https://github.com/daos-stack/pipeline-lib/blob/e6831a2ec6c8b9ee4ada79cd50aa91332fd98993/vars/skipStage.groovy#L489-L501.

In any case, that's how it's all supposed to work.

Signed-off-by: Phil Henderson <[email protected]>

Skip-func-hw-test: true Skip-func-test-leap15: false Signed-off-by: Phil Henderson <[email protected]>

Skip-func-hw-test: true Skip-func-test-leap15: false Required-githooks: true Signed-off-by: Phil Henderson <[email protected]>

Jenkinsfile

daosbuild1 · 2024-12-18T01:35:37Z

Test stage Functional on Leap 15.6 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15561/4/display/redirect

daosbuild1 · 2024-12-19T15:21:20Z

Test stage Functional on Leap 15.6 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15561/5/display/redirect

Skip-unit-tests: true Skip-func-hw-test: true Skip-func-test-leap15: false Required-githooks: true Signed-off-by: Phil Henderson <[email protected]>

daosbuild1 · 2024-12-19T16:45:59Z

Test stage Build RPM on Leap 15.5 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/6/execution/node/371/log

daosbuild1 · 2024-12-19T16:50:34Z

Test stage Build DEB on Ubuntu 20.04 completed with status UNSTABLE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/6/execution/node/354/log

Skip-unit-tests: true Skip-func-hw-test: true Skip-func-test-leap15: false Required-githooks: true Signed-off-by: Phil Henderson <[email protected]>

daosbuild1 · 2024-12-19T19:52:03Z

Test stage Functional on Leap 15.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/7/execution/node/871/log

Skip-unit-tests: true Skip-func-hw-test: true Skip-func-test-leap15: false Skip-func-test-el8: true Skip-fault-injection-test: true Required-githooks: true Signed-off-by: Phil Henderson <[email protected]>

phender · 2024-12-19T20:30:49Z

The Functional on Leap 15.6 stage passed in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15561/7 and the tests confirmed they ran on Leap 15.6. The pipeline-lib changes to support Leap 15.6 have been landed in daos-stack/pipeline-lib#450. So this is ready for final review.

daltonbohning

What about Build RPM on Leap 15.5? Isn't that what builds the RPMs for functional stages to use?

phender · 2024-12-19T20:36:54Z

What about Build RPM on Leap 15.5? Isn't that what builds the RPMs for functional stages to use?

https://daosio.atlassian.net/browse/DAOS-16500?focusedCommentId=134677. We can build the RPMs on 15.5 and install them and test on 15.6. When the opensuse-leap-15.6-x86_64.cfg mock.cfg file is available I can update the Jenkinsfile to build on 15.6.

daltonbohning · 2024-12-19T20:38:43Z

What about Build RPM on Leap 15.5? Isn't that what builds the RPMs for functional stages to use?

https://daosio.atlassian.net/browse/DAOS-16500?focusedCommentId=134677

So it seems we are building RPMs on Leap 15.5, then installing those lp155 on 15.6, right?
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15561/7/artifact/Functional%20on%20Leap%2015.6/launch/functional_on_leap_15.6/details.json

Then when that comment is resolved, we'll build lp156?

phender · 2024-12-19T20:39:24Z

What about Build RPM on Leap 15.5? Isn't that what builds the RPMs for functional stages to use?

https://daosio.atlassian.net/browse/DAOS-16500?focusedCommentId=134677

So it seems we are building RPMs on Leap 15.5, then installing those lp155 on 15.6, right? https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15561/7/artifact/Functional%20on%20Leap%2015.6/launch/functional_on_leap_15.6/details.json

Then when that comment is resolved, we'll build lp156?

Correct.

daosbuild1 · 2024-12-19T22:25:30Z

Test stage Functional on Leap 15.6 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15561/8/execution/node/821/log

Skip-unit-tests: true Skip-func-hw-test: true Skip-func-test-leap15: false Skip-func-test-el8: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

phender · 2024-12-21T04:04:36Z

All Functional on Leap 15.6 tests passed in https://build.hpdd.intel.com/job/daos-stack/job/daos/view/change-requests/job/PR-15561/10/testReport/

Test with Leap 15.6 instead of Leap 15.5. Skip-unit-tests: true Skip-func-hw-test: true Skip-func-test-leap15: false Skip-func-test-el8: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

DAOS-16500 build: Move to Leap 15.6

f895d44

Build and test with Leap 15.6 instead of Leap 15.5. Skip-func-hw-test: true Skip-func-test-leap15: false Required-githooks: true Signed-off-by: Phil Henderson <[email protected]>

phender requested a review from a team as a code owner December 4, 2024 16:55

phender requested a review from brianjmurrell December 4, 2024 16:55

brianjmurrell requested changes Dec 4, 2024

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

Jenkinsfile Outdated Show resolved Hide resolved

ci/parse_ci_envs.sh Outdated Show resolved Hide resolved

utils/rpms/packaging/Makefile_distro_vars.mk Outdated Show resolved Hide resolved

Applying feedback.

5feb645

Skip-func-hw-test: true Skip-func-test-leap15: false Required-githooks: true Signed-off-by: Phil Henderson <[email protected]>

phender requested a review from brianjmurrell December 4, 2024 22:47

brianjmurrell previously approved these changes Dec 10, 2024

View reviewed changes

phender added 3 commits December 10, 2024 09:20

Merge branch 'master' into pahender/DAOS-16500

67ce6e8

Signed-off-by: Phil Henderson <[email protected]>

Merge branch 'master' into pahender/DAOS-16500

82543f4

Skip-func-hw-test: true Skip-func-test-leap15: false Signed-off-by: Phil Henderson <[email protected]>

Update Test RPMs on Leap version to n-1.

46e15c2

Skip-func-hw-test: true Skip-func-test-leap15: false Required-githooks: true Signed-off-by: Phil Henderson <[email protected]>

phender dismissed brianjmurrell’s stale review via 46e15c2 December 17, 2024 17:24

phender requested a review from brianjmurrell December 17, 2024 17:24

phender commented Dec 17, 2024

View reviewed changes

Jenkinsfile Outdated Show resolved Hide resolved

brianjmurrell previously approved these changes Dec 17, 2024

View reviewed changes

Fix daos-client-tests requirement on Leap.

a90db9b

Skip-unit-tests: true Skip-func-hw-test: true Skip-func-test-leap15: false Required-githooks: true Signed-off-by: Phil Henderson <[email protected]>

phender dismissed brianjmurrell’s stale review via a90db9b December 19, 2024 16:28

Ignore rpmlint for libprotobuf-c-devel.

3e5bb5e

Skip-unit-tests: true Skip-func-hw-test: true Skip-func-test-leap15: false Required-githooks: true Signed-off-by: Phil Henderson <[email protected]>

Remove pipeline-lib ref.

f55809e

Skip-unit-tests: true Skip-func-hw-test: true Skip-func-test-leap15: false Skip-func-test-el8: true Skip-fault-injection-test: true Required-githooks: true Signed-off-by: Phil Henderson <[email protected]>

phender requested a review from daltonbohning December 19, 2024 20:27

phender requested a review from ryon-jensen December 19, 2024 20:27

daltonbohning reviewed Dec 19, 2024

View reviewed changes

daltonbohning approved these changes Dec 19, 2024

View reviewed changes

ryon-jensen approved these changes Dec 19, 2024

View reviewed changes

Merge branch 'master' into pahender/DAOS-16500

719ff08

Skip-unit-tests: true Skip-func-hw-test: true Skip-func-test-leap15: false Skip-func-test-el8: true Skip-fault-injection-test: true Signed-off-by: Phil Henderson <[email protected]>

phender merged commit 8984dd6 into master Dec 21, 2024
68 checks passed

phender deleted the pahender/DAOS-16500 branch December 21, 2024 04:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAOS-16500 build: Move to Leap 15.6 #15561

DAOS-16500 build: Move to Leap 15.6 #15561

phender commented Dec 4, 2024

daosbuild1 commented Dec 4, 2024

daosbuild1 commented Dec 4, 2024

daosbuild1 commented Dec 4, 2024

github-actions bot commented Dec 4, 2024 •

edited

Loading

daosbuild1 commented Dec 4, 2024

daosbuild1 commented Dec 4, 2024

brianjmurrell Dec 10, 2024

phender Dec 10, 2024

brianjmurrell Dec 10, 2024

daosbuild1 commented Dec 18, 2024

daosbuild1 commented Dec 19, 2024

daosbuild1 commented Dec 19, 2024

daosbuild1 commented Dec 19, 2024

daosbuild1 commented Dec 19, 2024

phender commented Dec 19, 2024

daltonbohning left a comment

phender commented Dec 19, 2024 •

edited

Loading

daltonbohning commented Dec 19, 2024

phender commented Dec 19, 2024

daosbuild1 commented Dec 19, 2024

phender commented Dec 21, 2024

DAOS-16500 build: Move to Leap 15.6 #15561

DAOS-16500 build: Move to Leap 15.6 #15561

Conversation

phender commented Dec 4, 2024

Before requesting gatekeeper:

Gatekeeper:

daosbuild1 commented Dec 4, 2024

daosbuild1 commented Dec 4, 2024

daosbuild1 commented Dec 4, 2024

github-actions bot commented Dec 4, 2024 • edited Loading

daosbuild1 commented Dec 4, 2024

daosbuild1 commented Dec 4, 2024

brianjmurrell Dec 10, 2024

Choose a reason for hiding this comment

phender Dec 10, 2024

Choose a reason for hiding this comment

brianjmurrell Dec 10, 2024

Choose a reason for hiding this comment

daosbuild1 commented Dec 18, 2024

daosbuild1 commented Dec 19, 2024

daosbuild1 commented Dec 19, 2024

daosbuild1 commented Dec 19, 2024

daosbuild1 commented Dec 19, 2024

phender commented Dec 19, 2024

daltonbohning left a comment

Choose a reason for hiding this comment

phender commented Dec 19, 2024 • edited Loading

daltonbohning commented Dec 19, 2024

phender commented Dec 19, 2024

daosbuild1 commented Dec 19, 2024

phender commented Dec 21, 2024

github-actions bot commented Dec 4, 2024 •

edited

Loading

phender commented Dec 19, 2024 •

edited

Loading