Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-623 client: Address java security scan #15542

Merged
merged 5 commits into from
Dec 5, 2024
Merged

DAOS-623 client: Address java security scan #15542

merged 5 commits into from
Dec 5, 2024

Conversation

jolivier23
Copy link
Contributor

Update netty-buffer to 4.1.115

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

Ticket title is 'Generic ticket for minor code cleanup and improvement'
Status is 'Resolved'
Labels: 'request_for_2.6.2'
https://daosio.atlassian.net/browse/DAOS-623

@daltonbohning
DAOS-16833 cq: update GHA ubuntu
b681559 
Update mantic (EOL) to oracular.
Update 22.04 LTS to 24.04 LTS.

Test-tag: pr,vm,-daos_test

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning
fix opt
bd8c933 
Test-tag: pr,vm,-daos_test

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@jolivier23
DAOS-623 client: Address java security scan
76e313f 
Update netty-buffer to 4.1.115

Required-githooks: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23 jolivier23 changed the base branch from master to dbohning/daos-16833 December 4, 2024 17:29
@jolivier23 jolivier23 requested a review from jiafuzha December 4, 2024 22:02
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15542/4/execution/node/1212/log

jiafuzha
jiafuzha previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@jiafuzha jiafuzha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from dbohning/daos-16833 to master December 5, 2024 15:43
@jolivier23 jolivier23 dismissed jiafuzha’s stale review December 5, 2024 15:43

The base branch was changed.

@jolivier23 jolivier23 marked this pull request as ready for review December 5, 2024 15:44
@jolivier23 jolivier23 requested review from a team as code owners December 5, 2024 15:44
@jolivier23
Merge branch 'master' into jvolivie/trivy
0baab01 
Required-githooks: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23
empty commit
f0fabad 
Required-githooks: true

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23 jolivier23 requested a review from jiafuzha December 5, 2024 15:47
@jolivier23 jolivier23 merged commit 837ed12 into master Dec 5, 2024
47 of 49 checks passed
@jolivier23 jolivier23 deleted the jvolivie/trivy branch December 5, 2024 17:06
jolivier23 added a commit that referenced this pull request Dec 6, 2024
@jolivier23
DAOS-623 client: Address java security scan (#15542)
e1ec4c4 
Update netty-buffer to 4.1.115

Signed-off-by: Jeff Olivier <[email protected]>
jolivier23 added a commit that referenced this pull request Dec 6, 2024
@jolivier23
DAOS-623 client: Address java security scan (#15542)
9888d52 
Update netty-buffer to 4.1.115

Signed-off-by: Jeff Olivier <[email protected]>
jolivier23 added a commit that referenced this pull request Dec 8, 2024
@jolivier23
DAOS-623 client: Address java security scan (#15542)
e043876 
Update netty-buffer to 4.1.115

Signed-off-by: Jeff Olivier <[email protected]>
daltonbohning pushed a commit that referenced this pull request Dec 13, 2024
@jolivier23 @daltonbohning
DAOS-623 client: Address java security scan (#15542)
a5650bc 
Update netty-buffer to 4.1.115

Signed-off-by: Jeff Olivier <[email protected]>
jolivier23 added a commit that referenced this pull request Dec 16, 2024
@daltonbohning @jolivier23
DAOS-623 client: Address java security scan (#15542) (#15615)
332f412 
Update netty-buffer to 4.1.115

Signed-off-by: Jeff Olivier <[email protected]>
Co-authored-by: Jeff Olivier <[email protected]>
@juszhan1 juszhan1 mentioned this pull request Dec 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

@mjmac mjmac mjmac approved these changes

@jiafuzha jiafuzha Awaiting requested review from jiafuzha

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jolivier23 @daosbuild1 @mjmac @daltonbohning @jiafuzha