Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16686 dfuse: Detect matching reads to avoid network access. #15528

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ashleypittman
Copy link
Contributor

If a read matches a current outstanding read then simply
connect the two and when there's a reply from the network
then respond to both requests.

Skip-func-test-vm: true
Test-tag: DaosBuild
Skip-fault-injection-test: true

Signed-off-by: Ashley Pittman [email protected]

If a read matches a current outstanding read then simply
connect the two and when there's a reply from the network
then respond to both requests.

Skip-func-test-vm: true
Test-tag: DaosBuild
Skip-fault-injection-test: true

Signed-off-by: Ashley Pittman <[email protected]>
Copy link

Ticket title is 'Concurrent reads hit the network even when caching enabled in dfuse'
Status is 'In Progress'
Labels: 'google-cloud-daos'
https://daosio.atlassian.net/browse/DAOS-16686

@ashleypittman ashleypittman marked this pull request as ready for review November 21, 2024 17:45
@ashleypittman ashleypittman requested review from a team as code owners November 21, 2024 17:45
@ashleypittman
Copy link
Contributor Author

This is a self-contained subset of #15298 and contains just the performance improvement for regular reads rather than any bug-fix to the chunk code. For now it's just running the tests which are failing in the other PR, the hope being that it passes and we can land this one as a way of moving forward whilst I debug why the others failing.

jolivier23
jolivier23 previously approved these changes Nov 22, 2024
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15528/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15528/3/execution/node/1476/log

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15528/4/testReport/

Skip-func-test-vm: true
Test-tag: DaosBuild
Skip-fault-injection-test: true
Allow-unstable-test: true
Required-githooks: true
Allow-unstable-test: true

Required-githooks: true
…i' into amd/dfuse-read-multi

Allow-unstable-test: true
Required-githooks: true
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15528/7/testReport/

wangdi1 added a commit that referenced this pull request Dec 18, 2024
From #15528

If a read matches a current outstanding read then simply
connect the two and when there's a reply from the network
then respond to both requests.

Ashley Pittman <[email protected]>
Required-githooks: true
wangdi1 added a commit that referenced this pull request Dec 20, 2024
From #15528

If a read matches a current outstanding read then simply
connect the two and when there's a reply from the network
then respond to both requests.

Ashley Pittman <[email protected]>
Required-githooks: true
wangdi1 added a commit that referenced this pull request Dec 28, 2024
From #15528

If a read matches a current outstanding read then simply
connect the two and when there's a reply from the network
then respond to both requests.

Ashley Pittman <[email protected]>
Required-githooks: true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants