Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16802 tests: properly set fault_injection for CR test - b26 #15510

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented Nov 18, 2024

Test-tag: test_daos_cat_recov_core
Allow-unstable-test: true
faults-enabled: false
Skip-nlt: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

github-actions bot commented Nov 18, 2024

Ticket title is 'recovery/cat_recov_core.py:CatRecovCoreTest.test_daos_cat_recov_core - Fault Injection not finalized feature not included in build'
Status is 'Awaiting backport'
Labels: '2.7.101tb,daily_test'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16802

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15510/1/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15510/1/execution/node/1349/log

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16802_b26 branch from cc33e17 to a469c46 Compare December 17, 2024 01:10
@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 17, 2024
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15510/2/testReport/

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15510/2/execution/node/1349/log

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15510/3/testReport/

@Nasf-Fan
Copy link
Contributor Author

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15510/3/testReport/

NIT failure is nothing related with the patch changes.

@Nasf-Fan Nasf-Fan marked this pull request as ready for review December 18, 2024 08:22
Copy link
Contributor

@phender phender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm this is working correctly the RPMs need to built/tested w/o fault injection, so the following commit pragma is required:

faults-enabled:  false

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16802_b26 branch from a469c46 to 09b2846 Compare December 19, 2024 02:17
@Nasf-Fan
Copy link
Contributor Author

Re-trigger test with "faults-enabled: false".

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16802_b26 branch from 09b2846 to b9b80b2 Compare December 19, 2024 16:21
Test-tag: test_daos_cat_recov_core
Allow-unstable-test: true
faults-enabled: false
Skip-nlt: true

Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16802_b26 branch from b9b80b2 to 91067e1 Compare December 20, 2024 03:19
@Nasf-Fan Nasf-Fan added clean-cherry-pick Cherry-pick from another branch that did not require additional edits release-2.6.3 Targeted for 2.6.3 labels Dec 25, 2024
@Nasf-Fan Nasf-Fan requested a review from a team December 25, 2024 02:21
@gnailzenh gnailzenh merged commit 776f123 into release/2.6 Dec 25, 2024
50 of 51 checks passed
@gnailzenh gnailzenh deleted the Nasf-Fan/DAOS-16802_b26 branch December 25, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed) release-2.6.3 Targeted for 2.6.3
Development

Successfully merging this pull request may close these issues.

5 participants