Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16175 container: fix a case for cont_iv_hdl_fetch #15395

Merged
merged 1 commit into from
Oct 28, 2024
Merged

DAOS-16175 container: fix a case for cont_iv_hdl_fetch #15395

merged 1 commit into from
Oct 28, 2024

Conversation

liuxuezhao
Copy link
Contributor

@liuxuezhao liuxuezhao commented Oct 25, 2024 •
edited
Loading

In reintegrate case, ever hit case that the IC_CONT_CAPA cache is valid locally
but cont open handle invalid (not in dt_cont_hdl_hash).
For this case invalidate local IV cache first and retry again, to avoid in-flight
UPDATE's failure because obj_ioc_init() -> ds_cont_find_hdl() ->
cont_iv_hdl_fetch() failure -
DBUG src/engine/server_iv.c:409 ivc_on_fetch() FETCH: Key [1:7] entry 0x7fb31063b550 valid yes
DBUG src/engine/server_iv.c:1042 iv_op_internal() class_id 7 opc 1 rc 0
ERR src/object/srv_obj.c:2174 obj_ioc_begin_lite()
Failed to initialize object I/O context.: DER_NO_HDL(-1002): 'Invalid handle'

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@liuxuezhao liuxuezhao requested review from a team as code owners October 25, 2024 08:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 25, 2024 •
edited
Loading

Ticket title is 'osa/online_reintegration.py:OSAOnlineReintegration.test_osa_online_reintegration - ior ERROR: dfs_write(0x558a3373e000, 40000) failed (22): Invalid argument'
Status is 'In Review'
Labels: '2.6.0rc2,2.6.1rc2,ci_2.6_provider,daily_test,ucx_provider,verbs_provider,weekly_test,ci_2.6_weekly'
https://daosio.atlassian.net/browse/DAOS-16175

@liuxuezhao
DAOS-16175 container: fix a case for cont_iv_hdl_fetch
ee2e8b5 
In reintegrate case, ever hit case that the IC_CONT_CAPA cache is valid locally
but cont open handle invalid (not in dt_cont_hdl_hash). For this case
invalidate local IV cache first and retry again, to avoid in-flight UPDATE's
failure because obj_ioc_init() -> ds_cont_find_hdl() ->
cont_iv_hdl_fetch() failure -
DBUG src/engine/server_iv.c:409 ivc_on_fetch() FETCH: Key [1:7] entry 0x7fb31063b550 valid yes
DBUG src/engine/server_iv.c:1042 iv_op_internal() class_id 7 opc 1 rc 0
ERR  src/object/srv_obj.c:2174 obj_ioc_begin_lite()
Failed to initialize object I/O context.: DER_NO_HDL(-1002): 'Invalid handle'

Signed-off-by: Xuezhao Liu <[email protected]>
@liuxuezhao liuxuezhao requested review from a team as code owners October 25, 2024 08:49
NiuYawei
NiuYawei approved these changes Oct 25, 2024
View reviewed changes
src/container/container_iv.c
*/
if (!invalidate_current) {
invalidate_current = true;
ABT_eventual_free(&eventual);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: use ABT_eventual_reset() here to avoid eventual creation on retry.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will change if this PR need refresh. Or by other PR later.

@liuxuezhao liuxuezhao requested review from kccain and removed request for a team October 25, 2024 08:58
@liuxuezhao liuxuezhao requested a review from a team October 28, 2024 02:45
@NiuYawei NiuYawei merged commit 947c76d into master Oct 28, 2024
52 of 54 checks passed
@NiuYawei NiuYawei deleted the lxz/cont_hdl_fix branch October 28, 2024 02:48
liuxuezhao added a commit that referenced this pull request Oct 28, 2024
@liuxuezhao
DAOS-16702 rebuild: restart rebuild for a massive failure case
eed3dc3 
In special massive failure case -
1. some engines down and triggered rebuild.
2. one engine participated the rebuild, not finished yet, it down again,
   the #failures exceeds pool RF and will not change pool map.
3. That engine restarted by administrator.

In that case should recover the rebuild task on the engine, to simplify it now just
abort and retry the global rebuild task.
No such issue by the typical recover approach that restart the whole
system including the PS leader.

another backport commit -
947c76d DAOS-16175 container: fix a case for cont_iv_hdl_fetch (#15395)

Skip-nlt: true

Signed-off-by: Xuezhao Liu <[email protected]>
@liuxuezhao liuxuezhao mentioned this pull request Oct 28, 2024
Merged
18 tasks
liuxuezhao added a commit that referenced this pull request Oct 30, 2024
@liuxuezhao
DAOS-16702 rebuild: restart rebuild for a massive failure case
0f3769a 
In special massive failure case -
1. some engines down and triggered rebuild.
2. one engine participated the rebuild, not finished yet, it down again,
   the #failures exceeds pool RF and will not change pool map.
3. That engine restarted by administrator.

In that case should recover the rebuild task on the engine, to simplify it now just
abort and retry the global rebuild task.
No such issue by the typical recover approach that restart the whole
system including the PS leader.

another backport commit -
947c76d DAOS-16175 container: fix a case for cont_iv_hdl_fetch (#15395)

Skip-nlt: true

Signed-off-by: Xuezhao Liu <[email protected]>
liuxuezhao added a commit that referenced this pull request Nov 3, 2024
@liuxuezhao
DAOS-16702 rebuild: restart rebuild for a massive failure case
0bfe900 
In special massive failure case -
1. some engines down and triggered rebuild.
2. one engine participated the rebuild, not finished yet, it down again,
   the #failures exceeds pool RF and will not change pool map.
3. That engine restarted by administrator.

In that case should recover the rebuild task on the engine, to simplify it now just
abort and retry the global rebuild task.
No such issue by the typical recover approach that restart the whole
system including the PS leader.

another backport commit -
947c76d DAOS-16175 container: fix a case for cont_iv_hdl_fetch (#15395)

Skip-nlt: true

Signed-off-by: Xuezhao Liu <[email protected]>
liuxuezhao added a commit that referenced this pull request Nov 5, 2024
@liuxuezhao
DAOS-16702 rebuild: restart rebuild for a massive failure case
9643482 
In special massive failure case -
1. some engines down and triggered rebuild.
2. one engine participated the rebuild, not finished yet, it down again,
   the #failures exceeds pool RF and will not change pool map.
3. That engine restarted by administrator.

In that case should recover the rebuild task on the engine, to simplify it now just
abort and retry the global rebuild task.
No such issue by the typical recover approach that restart the whole
system including the PS leader.

another backport commit -
947c76d DAOS-16175 container: fix a case for cont_iv_hdl_fetch (#15395)

Skip-nlt: true

Signed-off-by: Xuezhao Liu <[email protected]>
kccain pushed a commit that referenced this pull request Nov 7, 2024
@liuxuezhao @kccain
DAOS-16702 rebuild: restart rebuild for a massive failure case
1fc799b 
In special massive failure case -
1. some engines down and triggered rebuild.
2. one engine participated the rebuild, not finished yet, it down again,
   the #failures exceeds pool RF and will not change pool map.
3. That engine restarted by administrator.

In that case should recover the rebuild task on the engine, to simplify it now just
abort and retry the global rebuild task.
No such issue by the typical recover approach that restart the whole
system including the PS leader.

another backport commit -
947c76d DAOS-16175 container: fix a case for cont_iv_hdl_fetch (#15395)

Skip-nlt: true

Signed-off-by: Xuezhao Liu <[email protected]>
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
gnailzenh pushed a commit that referenced this pull request Dec 12, 2024
@liuxuezhao
DAOS-16702 rebuild: restart rebuild for a massive failure case (#15406)
d238ceb 
In special massive failure case -
1. some engines down and triggered rebuild.
2. one engine participated the rebuild, not finished yet, it down again,
   the #failures exceeds pool RF and will not change pool map.
3. That engine restarted by administrator.

In that case should recover the rebuild task on the engine, to simplify it now just
abort and retry the global rebuild task.
No such issue by the typical recover approach that restart the whole
system including the PS leader.

another backport commit -
947c76d DAOS-16175 container: fix a case for cont_iv_hdl_fetch (#15395)

Signed-off-by: Xuezhao Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiuYawei NiuYawei NiuYawei approved these changes

@wangshilong wangshilong wangshilong approved these changes

@kccain kccain Awaiting requested review from kccain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liuxuezhao @wangshilong @NiuYawei