Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16669 test: fix pool list ftest #15373

Merged
merged 4 commits into from
Oct 25, 2024
Merged

DAOS-16669 test: fix pool list ftest #15373

merged 4 commits into from
Oct 25, 2024

Conversation

knard-intel
Copy link
Contributor

@knard-intel knard-intel commented Oct 23, 2024 •
edited by tanabarr
Loading

Description

Fix regression on pool/list_verbose.py functional test introduced with DAOS-14419.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

Ticket title is 'pool/list_verbose.py:ListVerboseTest.test_fields_basic - dmg pool query disabled_ranks and query_mask differ'
Status is 'In Progress'
Labels: 'ci_master_weekly,weekly_test'
https://daosio.atlassian.net/browse/DAOS-16669

@kanard38 @knard-intel
DAOS-16669 test: fix pool list ftest
2fc50c6 
Fix regression on pool/list_verbose.py functional test introduced with
DAOS-14419.

Test-tag: ListVerboseTest
Required-githooks: true
Signed-off-by: Cedric Koch-Hofer <[email protected]>
@knard-intel knard-intel force-pushed the ckochhof/fix/master/daos-16669 branch from 4ad025e to 2fc50c6 Compare October 23, 2024 07:21
@kanard38 @knard-intel
DAOS-16669 test: fix pool list ftest
ec92092 
Add missing development dependencides to ansible scripts for building
ior.

Test-tag: ListVerboseTest
Required-githooks: true
Signed-off-by: Cedric Koch-Hofer <[email protected]>
tanabarr
tanabarr previously approved these changes Oct 23, 2024
View reviewed changes
utils/ansible/ftest/vars/Rocky8.yml Outdated
@@ -32,9 +32,11 @@ daos_base_deps:
daos_dev_deps:
rpms:
- daos-raft-devel
- daxctl-devel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: unrelated changes should probably be in their own PR to separate concerns

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, I needed these changes for running the functional test on my wolf subcluster.
This is why, I have integrated them in this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this should be separate. And since it's just ansible - not used in CI - we don't need to run all the Jenkins validation for a separate PR that just updates ansible

Copy link
Contributor Author

@knard-intel knard-intel Oct 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove the ansible script commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove the ansible script commit

Fixed with commit 6b1c150

@knard-intel knard-intel marked this pull request as ready for review October 23, 2024 15:35
@knard-intel knard-intel requested review from a team as code owners October 23, 2024 15:35
daltonbohning
daltonbohning reviewed Oct 23, 2024
View reviewed changes
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest LGTM but I agree with Tom on moving the ansible changes to a separate PR

utils/ansible/ftest/vars/Rocky8.yml Outdated
@@ -32,9 +32,11 @@ daos_base_deps:
daos_dev_deps:
rpms:
- daos-raft-devel
- daxctl-devel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this should be separate. And since it's just ansible - not used in CI - we don't need to run all the Jenkins validation for a separate PR that just updates ansible

shimizukko
shimizukko previously approved these changes Oct 24, 2024
View reviewed changes
@kanard38 @knard-intel
Merge remote-tracking branch 'origin/master' into ckochhof/fix/master…
2b3e05e 
…/daos-16669

Required-githooks: true
@kanard38 @knard-intel
DAOS-16669 test: fix pool list ftest
6b1c150 
Revert ansible script update of the commit ec92092

Test-tag: ListVerboseTest
Required-githooks: true
Signed-off-by: Cedric Koch-Hofer <[email protected]>
@knard-intel knard-intel dismissed stale reviews from shimizukko and tanabarr via 6b1c150 October 24, 2024 09:47
@knard-intel knard-intel requested review from a team and removed request for a team October 24, 2024 12:33
@tanabarr tanabarr requested a review from a team October 25, 2024 10:55
@phender phender merged commit df3dd24 into master Oct 25, 2024
57 of 58 checks passed
@phender phender deleted the ckochhof/fix/master/daos-16669 branch October 25, 2024 12:49
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
mjmac pushed a commit that referenced this pull request Dec 12, 2024
@knard-intel @mjmac
DAOS-16669 test: fix pool list ftest (#15373)
2fe9e74 
Fix regression on pool/list_verbose.py functional test introduced with
DAOS-14419.

Signed-off-by: Cedric Koch-Hofer <[email protected]>
@mjmac mjmac mentioned this pull request Dec 12, 2024
Merged
mjmac pushed a commit that referenced this pull request Dec 12, 2024
@knard-intel @mjmac
DAOS-16669 test: fix pool list ftest (#15373)
b4c94c2 
Fix regression on pool/list_verbose.py functional test introduced with
DAOS-14419.

Signed-off-by: Cedric Koch-Hofer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@shimizukko shimizukko shimizukko approved these changes

@tanabarr tanabarr tanabarr approved these changes

@mjmac mjmac Awaiting requested review from mjmac

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@knard-intel @tanabarr @shimizukko @daltonbohning @phender @kanard38