-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16645 cart: Bump file descriptor limit (#15224) #15366
Conversation
With tcp provider, using many sockets can cause significant file descriptor usage. Bump the soft limit, if possible and warn if it appears insufficient. Valgrind sets hard limit to soft limit, so work around that in NLT. Signed-off-by: Jeff Olivier <[email protected]>
Ticket title is 'Automatically bump soft file descriptor limit for tcp provider' |
Allow-unstable-test: true Required-githooks: true Signed-off-by: Jeff Olivier <[email protected]>
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15366/2/execution/node/1519/log |
Required-githooks: true Signed-off-by: Jeff Olivier <[email protected]>
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15366/4/testReport/ |
Required-githooks: true
Required-githooks: true Signed-off-by: Jeff Olivier <[email protected]>
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15366/5/testReport/ |
Required-githooks: true Signed-off-by: Jeff Olivier <[email protected]>
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15366/6/testReport/ |
Looks like 2.6 branch needs some valgrind backports to suppress go errors. |
This might be safe since it's a backport, but this PR does modify |
To fix NLT? |
yes, we are probably missing some valgrind backports
It doesn't fundamentally change NLT though. It just bumps the file descriptor limit to avoid a warning. |
FWIW we did just land this backport But if you're reasonable confident this PR is safe, no objection from me |
With tcp provider, using many sockets can cause significant file descriptor usage. Bump the soft limit, if possible and warn if it appears insufficient.
Valgrind sets hard limit to soft limit, so work around that in NLT.
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: