Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16645 cart: Bump file descriptor limit (#15224) #15366

Merged
merged 9 commits into from
Dec 19, 2024

Conversation

jolivier23
Copy link
Contributor

With tcp provider, using many sockets can cause significant file descriptor usage. Bump the soft limit, if possible and warn if it appears insufficient.
Valgrind sets hard limit to soft limit, so work around that in NLT.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

With tcp provider, using many sockets can cause significant
file descriptor usage.  Bump the soft limit, if possible
and warn if it appears insufficient.
Valgrind sets hard limit to soft limit, so work around that in NLT.

Signed-off-by: Jeff Olivier <[email protected]>
@jolivier23 jolivier23 marked this pull request as ready for review October 22, 2024 15:59
@jolivier23 jolivier23 requested review from a team as code owners October 22, 2024 15:59
@jolivier23 jolivier23 added clean-cherry-pick Cherry-pick from another branch that did not require additional edits approved-to-merge PR has received release branch merge approval labels Oct 22, 2024
Copy link

Ticket title is 'Automatically bump soft file descriptor limit for tcp provider'
Status is 'Awaiting backport'
Labels: 'google-cloud-daos'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16645

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Oct 22, 2024
Allow-unstable-test: true

Required-githooks: true

Signed-off-by: Jeff Olivier <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15366/2/execution/node/1519/log

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15366/4/testReport/

Required-githooks: true

Signed-off-by: Jeff Olivier <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15366/5/testReport/

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15366/6/testReport/

@jolivier23 jolivier23 added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Dec 17, 2024
@jolivier23
Copy link
Contributor Author

Looks like 2.6 branch needs some valgrind backports to suppress go errors.

@jolivier23 jolivier23 requested a review from a team December 17, 2024 15:08
@daltonbohning
Copy link
Contributor

This might be safe since it's a backport, but this PR does modify utils/node_local_test.py and NLT is failing

@daltonbohning
Copy link
Contributor

Looks like 2.6 branch needs some valgrind backports to suppress go errors.

To fix NLT?

@jolivier23
Copy link
Contributor Author

Looks like 2.6 branch needs some valgrind backports to suppress go errors.

To fix NLT?

yes, we are probably missing some valgrind backports

This might be safe since it's a backport, but this PR does modify utils/node_local_test.py and NLT is failing

It doesn't fundamentally change NLT though. It just bumps the file descriptor limit to avoid a warning.

@daltonbohning
Copy link
Contributor

FWIW we did just land this backport
79bf081

But if you're reasonable confident this PR is safe, no objection from me

@jolivier23 jolivier23 merged commit bf6a5b4 into release/2.6 Dec 19, 2024
73 of 75 checks passed
@jolivier23 jolivier23 deleted the jvolivie/bp_setrlimit branch December 19, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-to-merge PR has received release branch merge approval clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Development

Successfully merging this pull request may close these issues.

4 participants