Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16736 dfuse: Add a common struct for active IE data. #15362

Merged
merged 11 commits into from
Nov 8, 2024

Conversation

ashleypittman
Copy link
Contributor

@ashleypittman ashleypittman commented Oct 22, 2024

Create a active_inode struct and allocate it for all inodes which have more than
one open handle. This allows us to share state/caching data across open handles
easier and to better support concurrent readers. Future work here will improve
performance for concurrent readers when caching is used, and allow us to make
the in-memory inode struct smaller which will save memory.

Signed-off-by: Ashley Pittman [email protected]

Copy link

github-actions bot commented Oct 22, 2024

Ticket title is 'Per inode dfuse caching.'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16736

@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15362/1/testReport/

Test-tag: dfuse

Signed-off-by: Ashley Pittman <[email protected]>
Test-tag: dfuse
Signed-off-by: Ashley Pittman <[email protected]>
@ashleypittman ashleypittman changed the title DAOS-0000 dfuse: Add a common struct for active IE data. DAOS-16736 dfuse: Add a common struct for active IE data. Oct 22, 2024
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15362/3/execution/node/1186/log

Test-tag: dfuse
Signed-off-by: Ashley Pittman <[email protected]>
Test-tag: dfuse

Signed-off-by: Ashley Pittman <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15362/5/execution/node/1211/log

Test-tag: dfuse
Signed-off-by: Ashley Pittman <[email protected]>
Test-tag: dfuse
Signed-off-by: Ashley Pittman <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Build RPM on Leap 15.5 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15362/7/execution/node/383/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 9 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15362/7/execution/node/331/log

@daosbuild1
Copy link
Collaborator

Test stage Build RPM on EL 8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15362/7/execution/node/332/log

@daosbuild1
Copy link
Collaborator

Test stage Build DEB on Ubuntu 20.04 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15362/7/execution/node/380/log

@ashleypittman ashleypittman marked this pull request as ready for review October 24, 2024 16:09
@ashleypittman ashleypittman requested review from a team as code owners October 24, 2024 16:09
Copy link
Contributor

@mchaarawi mchaarawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15362/11/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15362/12/display/redirect

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15362/12/execution/node/1486/log

@ashleypittman ashleypittman requested a review from a team November 4, 2024 09:21
@ashleypittman
Copy link
Contributor Author

@daos-stack/daos-gatekeeper the only failures are unrelated rebuild tests.

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15362/13/execution/node/509/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15362/15/testReport/

@ashleypittman ashleypittman requested a review from wangdi1 November 5, 2024 22:47
@ashleypittman ashleypittman merged commit 47c1141 into master Nov 8, 2024
53 of 54 checks passed
@ashleypittman ashleypittman deleted the amd/common-ie-data branch November 8, 2024 08:54
wangdi1 pushed a commit that referenced this pull request Dec 18, 2024
Create a active_inode struct and allocate it for all inodes which have more than
one open handle. This allows us to share state/caching data across open handles
easier and to better support concurrent readers. Future work here will improve
performance for concurrent readers when caching is used, and allow us to make
the in-memory inode struct smaller which will save memory.

Signed-off-by: Ashley Pittman [email protected]
wangdi1 pushed a commit that referenced this pull request Dec 20, 2024
Create a active_inode struct and allocate it for all inodes which have more than
one open handle. This allows us to share state/caching data across open handles
easier and to better support concurrent readers. Future work here will improve
performance for concurrent readers when caching is used, and allow us to make
the in-memory inode struct smaller which will save memory.

Signed-off-by: Ashley Pittman [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants