Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16653 docs: Fix CRT_EVENT_DELAY description #15351

Merged
merged 1 commit into from
Oct 22, 2024
Merged

DAOS-16653 docs: Fix CRT_EVENT_DELAY description #15351

merged 1 commit into from
Oct 22, 2024
+1 −1

Conversation

liw
Copy link
Contributor

@liw liw commented Oct 21, 2024

Fix the description of the CRT_EVENT_DELAY environment variable in docs/admin/env_variables.md.

Doc-only: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@liw
DAOS-16653 docs: Fix CRT_EVENT_DELAY description
2cabd2b 
Fix the description of the CRT_EVENT_DELAY environment variable in
docs/admin/env_variables.md.

Doc-only: true
Signed-off-by: Li Wei <[email protected]>
Required-githooks: true
@github-actions GitHub Actions
Copy link

Ticket title is 'PS to wait for group stabilization before handling events'
Status is 'In Progress'
Job should run at elevated priority (1)
Errors are Unknown component
https://daosio.atlassian.net/browse/DAOS-16653

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Oct 21, 2024
@liw liw marked this pull request as ready for review October 21, 2024 02:46
@liw liw requested a review from a team as a code owner October 21, 2024 02:46
@liw liw requested a review from wangshilong October 21, 2024 04:51
@liw liw requested a review from a team October 22, 2024 02:47
@daltonbohning
Copy link
Contributor

Ticket title is 'PS to wait for group stabilization before handling events' Status is 'In Progress' Job should run at elevated priority (1) Errors are Unknown component https://daosio.atlassian.net/browse/DAOS-16653

Just FYI it should be doc: instead of docs:, but we can fix that on merge

@daltonbohning daltonbohning added forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. doc-only Changes only affect documentation, not code labels Oct 22, 2024
@daltonbohning daltonbohning merged commit c3b3e82 into master Oct 22, 2024
36 of 37 checks passed
@daltonbohning daltonbohning deleted the liw/ps-events-m1 branch October 22, 2024 16:52
liw added a commit that referenced this pull request Oct 23, 2024
@liw
DAOS-16653 docs: Fix CRT_EVENT_DELAY description (#15351)
6f002ba 
Fix the description of the CRT_EVENT_DELAY environment variable in
docs/admin/env_variables.md.

Signed-off-by: Li Wei <[email protected]>
Required-githooks: true
daltonbohning pushed a commit that referenced this pull request Oct 23, 2024
@liw
DAOS-16653 doc: Fix CRT_EVENT_DELAY description (#15351) (#15371)
dcf8419 
Fix the description of the CRT_EVENT_DELAY environment variable in
docs/admin/env_variables.md.

Signed-off-by: Li Wei <[email protected]>
This was referenced Oct 28, 2024
Closed
Closed
Closed
This was referenced Nov 6, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangshilong wangshilong wangshilong approved these changes

@frostedcmos frostedcmos frostedcmos approved these changes

@kccain kccain kccain approved these changes

Assignees
No one assigned
Labels
doc-only Changes only affect documentation, not code forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liw @daltonbohning @wangshilong @frostedcmos @kccain