Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16720 cq: pin isort to v1.1.0 #15338

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

daltonbohning
Copy link
Contributor

Pin isort to v1.1.0 to avoid suprprise changes and because v1.1.1 is not working for us.

Skip-build: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Pin isort to v1.1.0 to avoid suprprise changes and because v1.1.1 is not
working for us.

Skip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning self-assigned this Oct 17, 2024
Copy link

Ticket title is 'isort GHA failing'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16720

@daltonbohning
Copy link
Contributor Author

@daltonbohning daltonbohning marked this pull request as ready for review October 17, 2024 21:28
daltonbohning added a commit that referenced this pull request Oct 17, 2024
Pin isort to v1.1.0 to avoid suprprise changes and because v1.1.1 is not
working for us.

Skip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@@ -26,7 +26,7 @@ jobs:
- uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
with:
python-version: '3'
- uses: isort/isort-action@master
- uses: isort/isort-action@f14e57e1d457956c45a19c05a89cccdf087846e5 # v1.1.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the hash in the upstream repo for this action
isort/isort-action@f14e57e

@daltonbohning daltonbohning requested a review from a team October 17, 2024 21:46
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 17, 2024
@daltonbohning
Copy link
Contributor Author

Skipped Jenkins testing since this only modifies GHA

@daltonbohning daltonbohning merged commit 589dbf4 into master Oct 17, 2024
38 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16720 branch October 17, 2024 21:47
@ashleypittman
Copy link
Contributor

Do we know if dependabot will push upgrades for this action and if not can we update it, and have you checked for other actions that use master?

My fault this one, thank you for fixing it.

daltonbohning added a commit that referenced this pull request Oct 18, 2024
Pin isort to v1.1.0 to avoid suprprise changes and because v1.1.1 is not
working for us.

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning
Copy link
Contributor Author

Do we know if dependabot will push upgrades for this action and if not can we update it, and have you checked for other actions that use master?

My fault this one, thank you for fixing it.

Dependabot needs to be configured I think. I've not done it before, but I think this example looks straightforward
https://github.com/isort/isort-action/blob/master/.github/dependabot.yml

I haven't checked other actions.

@daltonbohning
Copy link
Contributor Author

Maybe this

version: 2
updates:
  - package-ecosystem: pip
    directory: /utils/cq/
    schedule:
      interval: daily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

4 participants