-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16720 cq: pin isort to v1.1.0 #15338
Conversation
Pin isort to v1.1.0 to avoid suprprise changes and because v1.1.1 is not working for us. Skip-build: true Required-githooks: true Signed-off-by: Dalton Bohning <[email protected]>
Ticket title is 'isort GHA failing' |
Pin isort to v1.1.0 to avoid suprprise changes and because v1.1.1 is not working for us. Skip-build: true Required-githooks: true Signed-off-by: Dalton Bohning <[email protected]>
@@ -26,7 +26,7 @@ jobs: | |||
- uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0 | |||
with: | |||
python-version: '3' | |||
- uses: isort/isort-action@master | |||
- uses: isort/isort-action@f14e57e1d457956c45a19c05a89cccdf087846e5 # v1.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the hash in the upstream repo for this action
isort/isort-action@f14e57e
Skipped Jenkins testing since this only modifies GHA |
Do we know if dependabot will push upgrades for this action and if not can we update it, and have you checked for other actions that use master? My fault this one, thank you for fixing it. |
Pin isort to v1.1.0 to avoid suprprise changes and because v1.1.1 is not working for us. Signed-off-by: Dalton Bohning <[email protected]>
Dependabot needs to be configured I think. I've not done it before, but I think this example looks straightforward I haven't checked other actions. |
Maybe this
|
Pin isort to v1.1.0 to avoid suprprise changes and because v1.1.1 is not working for us.
Skip-build: true
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: