Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16696 cart: Fix rc in error path #15313

Merged
merged 4 commits into from
Oct 21, 2024
Merged

DAOS-16696 cart: Fix rc in error path #15313

merged 4 commits into from
Oct 21, 2024

Conversation

frostedcmos
Copy link
Contributor

  • Fix rc in error path during ivo_on_update failure

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@frostedcmos
DAOS-16696 cart: Fix rc in error path
6d5f50c 
- Fix rc in error path during ivo_on_update failure

Required-githooks: true

Signed-off-by: Alexander A Oganezov <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

Ticket title is 'bulk_update_transfer_done_aux overrides rc on error'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16696

@frostedcmos
-style
03af8be 
Required-githooks: true

Signed-off-by: Alexander A Oganezov <[email protected]>
jolivier23
jolivier23 requested changes Oct 14, 2024
View reviewed changes
src/cart/crt_iv.c Outdated Show resolved Hide resolved
src/cart/crt_iv.c Outdated Show resolved Hide resolved
@frostedcmos
- fixes
64a3a4c 
Required-githooks: true

Signed-off-by: Alexander A Oganezov <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15313/3/testReport/

@frostedcmos frostedcmos marked this pull request as ready for review October 18, 2024 23:44
@frostedcmos frostedcmos requested review from a team as code owners October 18, 2024 23:44
@frostedcmos frostedcmos added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 21, 2024
@frostedcmos frostedcmos requested a review from a team October 21, 2024 15:57
@frostedcmos frostedcmos merged commit 711ecc7 into master Oct 21, 2024
55 checks passed
@frostedcmos frostedcmos deleted the aaoganez/DAOS-16696 branch October 21, 2024 16:35
frostedcmos added a commit that referenced this pull request Oct 21, 2024
@frostedcmos
DAOS-16696 cart: Fix rc in error path (#15313)
28165fe 
- Fix rc in error path during ivo_on_update failure

Required-githooks: true

Signed-off-by: Alexander A Oganezov <[email protected]>
frostedcmos added a commit that referenced this pull request Oct 22, 2024
@frostedcmos
DAOS-16696 cart: Fix rc in error path (#15313) (#15357)
42a0d35 
- Fix rc in error path during ivo_on_update failure

Required-githooks: true

Signed-off-by: Alexander A Oganezov <[email protected]>
This was referenced Oct 28, 2024
Closed
Closed
Closed
This was referenced Nov 6, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgmoore-or jgmoore-or jgmoore-or approved these changes

@jolivier23 jolivier23 jolivier23 approved these changes

@soumagne soumagne soumagne approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frostedcmos @daosbuild1 @soumagne @jolivier23 @jgmoore-or