DAOS-16693 telemetry: Avoid race between init/read #15306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ticket title is 'Race between add_metric() and d_tm_get_* causes segfaults' |
In rare cases, a reader may attempt to access a telemetry node after it has been added to the tree, but before it has been fully initialized. Use an atomic to prevent reads before the initialization has completed. Readers will instead get a -DER_AGAIN instead of crashing. Features: telemetry Required-githooks: true Change-Id: I12281a7db7ef70d5f827547af1233b7a6619ae6d Signed-off-by: Michael MacDonald <[email protected]>
mjmac
force-pushed
the
mjmac/DAOS-16693
branch
from
fc96994 to
2bb5b21
Compare
tanabarr
approved these changes
Oct 14, 2024
kjacque
approved these changes
Oct 15, 2024
|
IMO this is a good candidate for backport to 2.6.x. |
mjmac
added a commit
that referenced
this pull request
Oct 15, 2024
In rare cases, a reader may attempt to access a telemetry node after it has been added to the tree, but before it has been fully initialized. Use an atomic to prevent reads before the initialization has completed. Unlucky readers will get a -DER_AGAIN instead of crashing. Signed-off-by: Michael MacDonald <[email protected]>
jolivier23
pushed a commit
that referenced
this pull request
Oct 22, 2024
In rare cases, a reader may attempt to access a telemetry node after it has been added to the tree, but before it has been fully initialized. Use an atomic to prevent reads before the initialization has completed. Unlucky readers will get a -DER_AGAIN instead of crashing. Signed-off-by: Michael MacDonald <[email protected]>
This was referenced Oct 28, 2024
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rare cases, a reader may attempt to access a telemetry
node after it has been added to the tree, but before it
has been fully initialized. Use an atomic to prevent
reads before the initialization has completed. Unlucky
readers will get a -DER_AGAIN instead of crashing.
Features: telemetry
Required-githooks: true
Change-Id: I12281a7db7ef70d5f827547af1233b7a6619ae6d
Signed-off-by: Michael MacDonald [email protected]