-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16687 control: Handle missing PCIe caps in storage query usage #15296
Conversation
Ticket title is 'dmg storage query usage fails if no PCIe capabilities' |
b8cdd72
to
9ec6cc3
Compare
Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15296/2/execution/node/1431/log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for what I understand.
Features: control Required-githooks: true Signed-off-by: Tom Nabarro <[email protected]>
Features: control Required-githooks: true Signed-off-by: Tom Nabarro <[email protected]>
9ec6cc3
to
e2c41bf
Compare
Features: control Required-githooks: true Signed-off-by: Tom Nabarro <[email protected]>
…iutils-fix-nopciecaps Features: control Signed-off-by: Tom Nabarro <[email protected]>
…iutils-fix-nopciecaps Features: control Skip-nlt: true Required-githooks: true Signed-off-by: Tom Nabarro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fixes, thanks. The one issue remaining open for me is the assumption about the interaction between the incoming flags (meta vs. health). IMO needing to make an assumption like that is a sign that we need more granular flags coming in.
Features: control Required-githooks: true Signed-off-by: Tom Nabarro <[email protected]>
…iutils-fix-nopciecaps Features: control Signed-off-by: Tom Nabarro <[email protected]>
…15296) Missing PCIe capabilities when querying a NVMe SSD's configuration space is unusual but should be handled gracefully by the control-plane and shouldn't cause a failure to return usage statistics when calling dmg storage query usage. Update so that pciutils lib is only called when attempting to display health stats via dmg and not when fetching usage info. Improve clarity of workflow to ease maintenance and add test coverage for updates. Enable continued functionality when NVMe device doesn't return any extended capabilities in PCIe configuration space data by adding sentinel error to library for such a case. Features: control Required-githooks: true Signed-off-by: Tom Nabarro <[email protected]>
…15296) Missing PCIe capabilities when querying a NVMe SSD's configuration space is unusual but should be handled gracefully by the control-plane and shouldn't cause a failure to return usage statistics when calling dmg storage query usage. Update so that pciutils lib is only called when attempting to display health stats via dmg and not when fetching usage info. Improve clarity of workflow to ease maintenance and add test coverage for updates. Enable continued functionality when NVMe device doesn't return any extended capabilities in PCIe configuration space data by adding sentinel error to library for such a case. Features: control Required-githooks: true Signed-off-by: Tom Nabarro <[email protected]>
…15296) (#15392) Missing PCIe capabilities when querying a NVMe SSD's configuration space is unusual but should be handled gracefully by the control-plane and shouldn't cause a failure to return usage statistics when calling dmg storage query usage. Update so that pciutils lib is only called when attempting to display health stats via dmg and not when fetching usage info. Improve clarity of workflow to ease maintenance and add test coverage for updates. Enable continued functionality when NVMe device doesn't return any extended capabilities in PCIe configuration space data by adding sentinel error to library for such a case. Signed-off-by: Tom Nabarro <[email protected]>
Missing PCIe capabilities when querying a NVMe SSD's configuration
space is unusual but should be handled gracefully by the control-plane
and shouldn't cause a failure to return usage statistics when calling
dmg storage query usage.
Update so that pciutils lib is only called when attempting to display
health stats via dmg and not when fetching usage info. Improve clarity
of workflow to ease maintenance and add test coverage for updates.
Enable continued functionality when NVMe device doesn't return any
extended capabilities in PCIe configuration space data by adding
sentinel error to library for such a case.
Features: control
Required-githooks: true
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: