Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16650 control: dmg system exclude, update group version #15288

Merged
merged 2 commits into from
Oct 16, 2024
Merged

DAOS-16650 control: dmg system exclude, update group version #15288

merged 2 commits into from
Oct 16, 2024

Conversation

kccain
Copy link
Contributor

@kccain kccain commented Oct 9, 2024

With this change, when a daos administrator runs dmg system exclude for a given set of engines, the system map version / cart primary group version will be updated. In turn, daos_engines will more immediately detect the "loss" of the administratively excluded engines, update pool maps and perform rebuild. This change supports a use case of a proactive exclusion of ranks that are expected to be impacted by planned maintenance that would cut off connectivity to certain engines.

Features: control ms_membership

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@kccain
DAOS-16650 control: dmg system exclude, update group version
09449d0 
With this change, when a daos administrator runs dmg system exclude
for a given set of engines, the system map version / cart primary group
version will be updated. In turn, daos_engines will more immediately
detect the "loss" of the administratively excluded engines, update
pool maps and perform rebuild. This change supports a use case of
a proactive exclusion of ranks that are expected to be impacted by
planned maintenance that would cut off connectivity to certain
engines.

Features: control ms_membership

Signed-off-by: Kenneth Cain <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

Ticket title is 'DAOS 2.6.0 : 128 Node cluster, when user tried to start the few stopped engines, Different engine got crashed.'
Status is 'In Progress'
Labels: 'ALCF'
https://daosio.atlassian.net/browse/DAOS-16650

@kccain kccain marked this pull request as ready for review October 10, 2024 17:36
@kccain kccain requested review from a team as code owners October 10, 2024 17:36
@kccain
address review feedback from Mike for unit test
dc0882c 
Skip-nlt: true
Skip-func-test: true

Signed-off-by: Kenneth Cain <[email protected]>
@kccain kccain requested a review from ravalsam October 14, 2024 14:09
knard38
knard38 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kccain kccain requested a review from a team October 15, 2024 13:20
@kccain
Copy link
Contributor Author

kccain commented Oct 15, 2024

@daos-stack/daos-gatekeeper the control plane implementation change was tested in Jenkins build 1 https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15288/1/pipeline-graph/ , and a modification to the unit test only code was tested in build 2 (that skipped functional testing due to the test-only code change) https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15288/2/pipeline-graph/

kjacque
kjacque approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@kjacque kjacque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Comments are minor, no need to bother unless you're repushing anyway.

src/control/server/mgmt_system_test.go

startMapVer, err := svc.sysdb.CurMapVersion()
if err != nil {
t.Fatalf("startMapVer CurMapVersion() failed\n")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, no newline needed at the end of the message

src/control/server/mgmt_system_test.go
for {
curMapVer, err := svc.sysdb.CurMapVersion()
if err != nil {
t.Fatalf("CurMapVersion() failed\n")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 16, 2024
@daltonbohning
Copy link
Contributor

FYI skipping stages on the final commit means the PR requires force landing. But in this case I can see it was just unit tests modified.

@daltonbohning daltonbohning merged commit 0e42449 into master Oct 16, 2024
49 checks passed
@daltonbohning daltonbohning deleted the kccain/daos_16650_sysexclude branch October 16, 2024 00:55
kccain added a commit that referenced this pull request Oct 20, 2024
@kccain
DAOS-16650 control: dmg system exclude, update group version (#15288)
3e4b308 
With this change, when a daos administrator runs dmg system exclude
for a given set of engines, the system map version / cart primary group
version will be updated. In turn, daos_engines will more immediately
detect the "loss" of the administratively excluded engines, update
pool maps and perform rebuild. This change supports a use case of
a proactive exclusion of ranks that are expected to be impacted by
planned maintenance that would cut off connectivity to certain
engines.

Features: control ms_membership

Signed-off-by: Kenneth Cain <[email protected]>
kccain added a commit that referenced this pull request Oct 21, 2024
@kccain
DAOS-16650 control: dmg system exclude, update group version (#15288)
5b918d0 
With this change, when a daos administrator runs dmg system exclude
for a given set of engines, the system map version / cart primary group
version will be updated. In turn, daos_engines will more immediately
detect the "loss" of the administratively excluded engines, update
pool maps and perform rebuild. This change supports a use case of
a proactive exclusion of ranks that are expected to be impacted by
planned maintenance that would cut off connectivity to certain
engines.

skip-nlt: true
Features: control ms_membership

Signed-off-by: Kenneth Cain <[email protected]>
daltonbohning pushed a commit that referenced this pull request Oct 23, 2024
@kccain
DAOS-16650 control: dmg system exclude, update group version (#15288) (…
4c49f36 
…#15349)

With this change, when a daos administrator runs dmg system exclude
for a given set of engines, the system map version / cart primary group
version will be updated. In turn, daos_engines will more immediately
detect the "loss" of the administratively excluded engines, update
pool maps and perform rebuild. This change supports a use case of
a proactive exclusion of ranks that are expected to be impacted by
planned maintenance that would cut off connectivity to certain
engines.

Signed-off-by: Kenneth Cain <[email protected]>
This was referenced Oct 28, 2024
Closed
Closed
Closed
This was referenced Nov 6, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knard38 knard38 knard38 approved these changes

@kjacque kjacque kjacque approved these changes

@mjmac mjmac mjmac approved these changes

@ravalsam ravalsam Awaiting requested review from ravalsam

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kccain @daltonbohning @mjmac @kjacque @knard38