Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15943 test: Remove server logging from pre-teardown #15282

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

mjean308
Copy link
Contributor

@mjean308 mjean308 commented Oct 9, 2024

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: soak_smoke

Required-githooks: true
Skipped-githooks: flake,pylint

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: soak_smoke

Required-githooks: true
Skipped-githooks: flake,pylint

Signed-off-by: Maureen Jean <[email protected]>
@mjean308 mjean308 requested review from a team as code owners October 9, 2024 13:34
Copy link

github-actions bot commented Oct 9, 2024

Ticket title is 'soak: improve server log collection'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-15943

Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to address the lint errors
https://github.com/daos-stack/daos/actions/runs/11256119170
But otherwise LGTM

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: soak_smoke

Required-githooks: true
Skipped-githooks: flake,pylint

Signed-off-by: Maureen Jean <[email protected]>
@mjean308 mjean308 requested a review from a team October 24, 2024 12:55
@phender phender merged commit 45b8c75 into master Oct 24, 2024
45 of 46 checks passed
@phender phender deleted the mjean/DAOS-15943 branch October 24, 2024 13:15
mjean308 added a commit that referenced this pull request Oct 24, 2024
phender pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants