Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16550 test: use correct stonewall file with mdtest (#15109) #15249

Merged
merged 1 commit into from
Oct 7, 2024
Merged

DAOS-16550 test: use correct stonewall file with mdtest (#15109) #15249

merged 1 commit into from
Oct 7, 2024

Conversation

daltonbohning
Copy link
Contributor

Use a dynamic stonewall file with mdtest instead of hardcoded path.

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning
DAOS-16550 test: use correct stonewall file with mdtest (#15109)
4ef7dde 
Use a dynamic stonewall file with mdtest instead of hardcoded path.

Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning self-assigned this Oct 4, 2024
@daltonbohning daltonbohning added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Ticket title is 'ftest: use correct stonewall file for mdtest'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16550

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Oct 4, 2024
@daltonbohning daltonbohning marked this pull request as ready for review October 5, 2024 18:06
@daltonbohning daltonbohning requested review from a team as code owners October 5, 2024 18:06
@daltonbohning daltonbohning requested a review from a team October 7, 2024 16:16
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 7, 2024
@daltonbohning daltonbohning merged commit b3868b6 into release/2.6 Oct 7, 2024
45 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16550-2.6 branch October 7, 2024 16:17
This was referenced Oct 7, 2024
Closed
Closed
@techbasset techbasset mentioned this pull request Oct 8, 2024
Closed
daltonbohning added a commit that referenced this pull request Oct 10, 2024
@daltonbohning
DAOS-16550 test: use correct stonewall file with mdtest (#15109) (#15249
66cea0c 
)

Use a dynamic stonewall file with mdtest instead of hardcoded path.

Signed-off-by: Dalton Bohning <[email protected]>
@techbasset techbasset mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpadma2 rpadma2 rpadma2 approved these changes

@shimizukko shimizukko shimizukko approved these changes

@phender phender Awaiting requested review from phender

Assignees

@daltonbohning daltonbohning

Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daltonbohning @shimizukko @rpadma2