Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16556 client: call fstat() before mmap() to update file status in kernel #15244

Merged
merged 1 commit into from
Oct 10, 2024
Merged

DAOS-16556 client: call fstat() before mmap() to update file status in kernel #15244

merged 1 commit into from
Oct 10, 2024

Conversation

wiliamhuang
Copy link
Contributor

In the compatible mode of libpil4dfs, write() is done in user mode. We need to let kernel to update file status before calling mmap().

Features: pil4dfs
Skip-func-test-leap15: false
Skip-func-vm-test-leap15: false

Required-githooks: true
Skipped-githooks: codespell

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@wiliamhuang
DAOS-16556 client: call fstat() before mmap() to update file status i…
3dd4785 
…n kernel

Features: pil4dfs
Skip-func-test-leap15: false
Skip-func-vm-test-leap15: false

Required-githooks: true
Skipped-githooks: codespell

Signed-off-by: Lei Huang <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Ticket title is 'dfuse/daos_build.py:DaosBuild.test_dfuse_daos_build_wt_pil4df - Failure to build over dfuse with il in mode nocache'
Status is 'Open'
Labels: '2.6.1rc1,2.6.1rc2,weekly_test,intercept_lib'
https://daosio.atlassian.net/browse/DAOS-16556

@wiliamhuang
Copy link
Contributor Author

All tests in CI (including Functional on Leap 15.5) passed.

@wiliamhuang wiliamhuang marked this pull request as ready for review October 7, 2024 12:16
@wiliamhuang wiliamhuang requested review from a team as code owners October 7, 2024 12:16
ashleypittman
ashleypittman approved these changes Oct 7, 2024
View reviewed changes
src/client/dfuse/pil4dfs/int_dfs.c
@@ -6302,6 +6302,14 @@ new_mmap(void *addr, size_t length, int prot, int flags, int fd, off_t offset)

atomic_fetch_add_relaxed(&num_mmap, 1);

if ((fd < FD_FILE_BASE) && (fd_directed >= FD_FILE_BASE) && d_compatible_mode) {
/* DAOS-14494: Force the kernel to update the size before mapping. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've linked DAOS-14494 and DAOS-16556 in Jira.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thank you very much!

@wiliamhuang
Copy link
Contributor Author

@mchaarawi Could you please review this PR when you have time? It is a small one. Thank you very much!

@wiliamhuang wiliamhuang requested a review from a team October 10, 2024 19:50
@wiliamhuang
Copy link
Contributor Author

@mchaarawi Shall we back port this PR to 2.6? Thank you!

@mchaarawi mchaarawi merged commit 032849e into master Oct 10, 2024
55 of 56 checks passed
@mchaarawi mchaarawi deleted the lei/DAOS-16556 branch October 10, 2024 19:52
@mchaarawi
Copy link
Contributor

@mchaarawi Shall we back port this PR to 2.6? Thank you!

yes makes sense to do that

wiliamhuang added a commit that referenced this pull request Oct 12, 2024
@wiliamhuang
DAOS-16556 client: call fstat() before mmap() to update file status i…
e38d253 
…n kernel (#15244)

Signed-off-by: Lei Huang <[email protected]>
@wiliamhuang wiliamhuang mentioned this pull request Oct 12, 2024
Merged
18 tasks
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchaarawi mchaarawi mchaarawi approved these changes

@ashleypittman ashleypittman ashleypittman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wiliamhuang @mchaarawi @ashleypittman