-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16574 vos: shrink DTX table blob size #15220
Conversation
Ticket title is 'After performing a pool extend, noticing rebuild timeouts on soak offline harasser testing [2.6.1-rc1]' |
Use 4KB blob for committed DTX table and 16KB for active DTX table. It is more efficient for lower allocator and reduce the possibility of space allocation failure when space pressure. Simplify vos_dtx_commit logic and code cleanup. Signed-off-by: Fan Yong <[email protected]>
09b3f22
to
511b57f
Compare
Ping reviewers, thanks! |
/* 16 KB blob for each active DTX blob */ | ||
#define DTX_ACT_BLOB_SIZE (1 << 14) | ||
/* 4 KB for committed DTX blob */ | ||
#define DTX_CMT_BLOB_SIZE (1 << 12) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should introduce 2 slabs for these 2 sizes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is possible, but not sure how much it will help since the table blob is not allocated for each DTX entry, instead, it will be allocated per tens of or hundreds of DTX entries.
Use 4KB blob for committed DTX table and 16KB for active DTX table. It is more efficient for lower allocator and reduce the possibility of space allocation failure when space pressure. Simplify vos_dtx_commit logic and code cleanup. Signed-off-by: Fan Yong <[email protected]>
Use 4KB blob for committed DTX table and 16KB for active DTX table. It is more efficient for lower allocator and reduce the possibility of space allocation failure when space pressure.
Simplify vos_dtx_commit logic and code cleanup.
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: