Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16574 vos: shrink DTX table blob size #15220

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

Nasf-Fan
Copy link
Contributor

Use 4KB blob for committed DTX table and 16KB for active DTX table. It is more efficient for lower allocator and reduce the possibility of space allocation failure when space pressure.

Simplify vos_dtx_commit logic and code cleanup.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Copy link

Ticket title is 'After performing a pool extend, noticing rebuild timeouts on soak offline harasser testing [2.6.1-rc1]'
Status is 'In Progress'
Labels: 'manual_test,soak,2.6.1_issue'
https://daosio.atlassian.net/browse/DAOS-16574

Use 4KB blob for committed DTX table and 16KB for active DTX table.
It is more efficient for lower allocator and reduce the possibility
of space allocation failure when space pressure.

Simplify vos_dtx_commit logic and code cleanup.

Signed-off-by: Fan Yong <[email protected]>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-16574_1 branch from 09b3f22 to 511b57f Compare October 1, 2024 16:27
@Nasf-Fan Nasf-Fan marked this pull request as ready for review October 2, 2024 04:05
@Nasf-Fan Nasf-Fan requested review from a team as code owners October 2, 2024 04:05
@Nasf-Fan
Copy link
Contributor Author

Ping reviewers, thanks!

/* 16 KB blob for each active DTX blob */
#define DTX_ACT_BLOB_SIZE (1 << 14)
/* 4 KB for committed DTX blob */
#define DTX_CMT_BLOB_SIZE (1 << 12)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should introduce 2 slabs for these 2 sizes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is possible, but not sure how much it will help since the table blob is not allocated for each DTX entry, instead, it will be allocated per tens of or hundreds of DTX entries.

@Nasf-Fan Nasf-Fan requested a review from a team October 14, 2024 04:31
@gnailzenh gnailzenh merged commit 07f2906 into master Oct 15, 2024
54 of 55 checks passed
@gnailzenh gnailzenh deleted the Nasf-Fan/DAOS-16574_1 branch October 15, 2024 15:58
daltonbohning pushed a commit that referenced this pull request Oct 22, 2024
Use 4KB blob for committed DTX table and 16KB for active DTX table.
It is more efficient for lower allocator and reduce the possibility
of space allocation failure when space pressure.

Simplify vos_dtx_commit logic and code cleanup.

Signed-off-by: Fan Yong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants