Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16634 mercury: Update source build in release 2.6 with ucx patch. #15214

Merged
merged 3 commits into from
Oct 1, 2024
Merged

DAOS-16634 mercury: Update source build in release 2.6 with ucx patch. #15214

merged 3 commits into from
Oct 1, 2024

Conversation

jgmoore-or
Copy link
Contributor

@jgmoore-or jgmoore-or commented Sep 27, 2024 •
edited
Loading

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@jgmoore-or
DAOS-16634 mercury: Update source build in release 2.6 for latest ucx…
f481359 
… patch.

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@github-actions GitHub Actions
Copy link

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-16634

@jgmoore-or jgmoore-or changed the title DAOS-16634 mercury: Update source build in release 2.6 for latest ucx… DAOS-16634 mercury: Update source build in release 2.6 with ucx patch. Sep 27, 2024
@jgmoore-or
DAOS-16634 mercury: Update to latest ucx patch.
44095e8 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-func-test-vm: true
Skip-unit-tests: true
Skip-nlt: true
Test-tag: pr daily_regression
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
PR-repos: mercury@PR-123:2
Test-provider: ucx+ud_x

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15214/3/execution/node/910/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15214/3/execution/node/884/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15214/4/execution/node/863/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15214/4/execution/node/847/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15214/4/execution/node/1004/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15214/5/execution/node/909/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15214/5/execution/node/847/log

mchaarawi
mchaarawi previously approved these changes Oct 1, 2024
View reviewed changes
@jgmoore-or jgmoore-or added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 1, 2024
@jgmoore-or jgmoore-or requested a review from a team October 1, 2024 16:15
@phender phender merged commit 1044efa into release/2.6 Oct 1, 2024
45 of 46 checks passed
@phender phender deleted the jgm/DAOS-16634-2.6 branch October 1, 2024 18:18
This was referenced Oct 7, 2024
Closed
Closed
This was referenced Oct 8, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumagne soumagne soumagne approved these changes

@phender phender Awaiting requested review from phender

@frostedcmos frostedcmos Awaiting requested review from frostedcmos

@mchaarawi mchaarawi Awaiting requested review from mchaarawi

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgmoore-or @daosbuild1 @soumagne @mchaarawi @phender