Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16634 cart: Test DAOS with Mercury UCX updates. #15205

Merged
merged 5 commits into from
Oct 1, 2024
Merged

DAOS-16634 cart: Test DAOS with Mercury UCX updates. #15205

merged 5 commits into from
Oct 1, 2024

Conversation

jgmoore-or
Copy link
Contributor

PR-repos: mercury@PR-123:1
Test-provider: ucx+dc_mlx5

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@jgmoore-or
DAOS-16634 cart: Test DAOS with Mercury UCX updates.
c1a40d2 
PR-repos: mercury@PR-123:1
Test-provider: ucx+dc_mlx5

Signed-off-by: Joseph Moore <[email protected]>
@jgmoore-or jgmoore-or requested review from a team as code owners September 26, 2024 20:06
@jgmoore-or jgmoore-or marked this pull request as draft September 26, 2024 20:06
@github-actions GitHub Actions
Copy link

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-16634

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15205/2/execution/node/1056/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15205/2/execution/node/1035/log

@jgmoore-or
DAOS-16634 mecury: Update source build to use latest na_ucx. patch.
a3ed405 
Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@jgmoore-or
DAOS-16634 cart: Test DAOS with Mercury UCX updates.
d04506a 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-func-test-vm: true
Skip-unit-tests: true
Test-tag: pr daily_regression
Test-provider: ucx+ud_x
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
PR-repos: mercury@PR-123:4

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15205/5/execution/node/910/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium UCX Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15205/5/execution/node/818/log

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15205/5/execution/node/864/log

@jgmoore-or
DAOS-16634 cart: Test DAOS with ucx fixes.
b03bff0 
Skip-build-leap15-icc: true
Skip-build-el8-gcc: true
Skip-func-test-vm: true
Skip-unit-tests: true
Test-provider: ucx+ud_x
Skip-func-hw-test-medium-ucx-provider: false
Skip-func-hw-test-medium-verbs-provider: true
PR-repos: mercury@PR-123:4

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
mchaarawi
mchaarawi previously approved these changes Oct 1, 2024
View reviewed changes
@jgmoore-or
DAOS-16634 mercury: Update DAOS source builds to latest Mercury UCX p…
0dc4758 
…atch.

Required-githooks: true

Signed-off-by: Joseph Moore <[email protected]>
@jgmoore-or jgmoore-or marked this pull request as ready for review October 1, 2024 15:03
@phender
Copy link
Contributor

phender commented Oct 1, 2024

https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15205/9/ was manually stopped as unit testing had passed and functional testing is not required for this change.

@phender phender requested a review from a team October 1, 2024 16:12
@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Oct 1, 2024
@phender phender merged commit abf9c8c into master Oct 1, 2024
50 of 52 checks passed
@phender phender deleted the jgm/DAOS-16634 branch October 1, 2024 16:13
@mchaarawi
Copy link
Contributor

mchaarawi commented Oct 1, 2024 •
edited
Loading

the PR title was wrong here since it's build and not cart and it's updating the mercury build not a testing PR.. but i guess it's done now. for next time please make sure the PR accurately reflects the purpose

@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@soumagne soumagne soumagne approved these changes

@frostedcmos frostedcmos Awaiting requested review from frostedcmos

@mchaarawi mchaarawi Awaiting requested review from mchaarawi

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgmoore-or @daosbuild1 @phender @mchaarawi @soumagne