-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-14408 common: ensure NDCTL not used for storage class ram
#15203
Conversation
Ticket title is 'NDCTL must be enabled to provide support for RAS functionality in PMDK' |
Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15203/1/testReport/ |
This PR prepares DAOS to be used with NDCTL enabled in PMDK, which means: - NDCTL must not be used when non-DCPM (simulate PMem) - `storage class: "ram"` is used: `PMEMOBJ_CONF=sds.at_create=0` env variable disables NDCTL features in the PMDK This change affects all tests run on simulated PMem (e.g. inside VMs). Some DOAS utility applications may also require `PMEMOBJ_CONF=sds.at_create=0` to be set. - The default ULT stack size must be at least 20KiB to avoid stack overuse by PMDK with NDCTL enabled and be aligned with Linux page size. `ABT_THREAD_STACKSIZE=20480` env variable is used to increase the default ULT stack size. This env variable is set by control/server module just before engine is started. Much bigger stack is used for pmempool open/create-related tasks e.g. `tgt_vos_create_one` to avoid stack overusage. This modification shall not affect md-on-ssd mode as long as `storage class: "ram"` is used for the first tier in the `storage` configuration. This change does not require any configuration changes to existing systems. The new PMDK package with NDCTL enabled (daos-stack/pmdk#38) will land as soon as this PR is merged. Allow-unstable-test: true Priority: 2 Required-githooks: true Signed-off-by: Tomasz Gromadzki <[email protected]>
09cab12
to
70d7a95
Compare
PR-repos: pmdk@PR-38:14 Skip-list: test_dfuse_daos_build_wt_pil4dfs:DAOS-16556 Priority: 2 Cancel-prev-build: false Force tests on various OSes Skip-func-test-leap15: false Skip-func-test-el9: false Skip-test-leap-15.4-rpms: false Skip-test-el9-rpms: false Allow-unstable-test: true Required-githooks: true Signed-off-by: Tomasz Gromadzki <[email protected]>
70d7a95
to
2efa66c
Compare
PR-repos: pmdk@PR-38:14 Skip-list: test_dfuse_daos_build_wt_pil4dfs:DAOS-16556 Priority: 2 Cancel-prev-build: false Force tests on various OSes Skip-func-test-leap15: false Skip-func-test-el9: false Skip-test-leap-15.4-rpms: false Skip-test-el9-rpms: false Allow-unstable-test: true Required-githooks: true Signed-off-by: Tomasz Gromadzki <[email protected]>
PR-repos: pmdk@PR-38:14 Skip-list: test_dfuse_daos_build_wt_pil4dfs:DAOS-16556 Priority: 2 Cancel-prev-build: false Skip-nlt: true Force tests on various OSes Skip-func-test-leap15: false Skip-func-test-el9: false Skip-test-leap-15.4-rpms: false Skip-test-el9-rpms: false Allow-unstable-test: true Required-githooks: true Signed-off-by: Tomasz Gromadzki <[email protected]>
PR-repos: pmdk@PR-38:14 Skip-list: test_dfuse_daos_build_wt_pil4dfs:DAOS-16556 Priority: 2 Cancel-prev-build: false Skip-nlt: true Force tests on various OSes Skip-func-test-leap15: false Skip-func-test-el9: false Skip-test-leap-15.4-rpms: false Skip-test-el9-rpms: false Allow-unstable-test: true Required-githooks: true Signed-off-by: Jan Michalski <[email protected]>
PR-repos: pmdk@PR-38:14 Skip-list: test_dfuse_daos_build_wt_pil4dfs:DAOS-16556 Priority: 2 Cancel-prev-build: false Skip-nlt: false Skip-unit-test-memcheck: true Skip-unit-test: true Skip-func-test: true Required-githooks: true Signed-off-by: Tomasz Gromadzki <[email protected]>
https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15203/8/ has NLT failures which I don't think are related to the PR |
Doc-only: true Required-githooks: true Signed-off-by: Tomasz Gromadzki <[email protected]>
) * DAOS-14408 common: enable NDCTL for DCPM This PR prepares DAOS to be used with NDCTL enabled in PMDK, which means: - NDCTL must not be used when non-DCPM (simulate PMem) - `storage class: "ram"` is used: `PMEMOBJ_CONF=sds.at_create=0` env variable disables NDCTL features in the PMDK This change affects all tests run on simulated PMem (e.g. inside VMs). Some DOAS utility applications may also require `PMEMOBJ_CONF=sds.at_create=0` to be set. - The default ULT stack size must be at least 20KiB to avoid stack overuse by PMDK with NDCTL enabled and be aligned with Linux page size. `ABT_THREAD_STACKSIZE=20480` env variable is used to increase the default ULT stack size. This env variable is set by control/server module just before engine is started. Much bigger stack is used for pmempool open/create-related tasks e.g. `tgt_vos_create_one` to avoid stack overusage. This modification shall not affect md-on-ssd mode as long as `storage class: "ram"` is used for the first tier in the `storage` configuration. This change does not require any configuration changes to existing systems. The new PMDK package with NDCTL enabled (daos-stack/pmdk#38) will land as soon as this PR is merged. Required-githooks: true Change-Id: If4c3f7d88a97e4e4f5526da71f4b374a2844057b Signed-off-by: Jan Michalski <[email protected]>
) * DAOS-14408 common: enable NDCTL for DCPM This PR prepares DAOS to be used with NDCTL enabled in PMDK, which means: - NDCTL must not be used when non-DCPM (simulate PMem) - `storage class: "ram"` is used: `PMEMOBJ_CONF=sds.at_create=0` env variable disables NDCTL features in the PMDK This change affects all tests run on simulated PMem (e.g. inside VMs). Some DOAS utility applications may also require `PMEMOBJ_CONF=sds.at_create=0` to be set. - The default ULT stack size must be at least 20KiB to avoid stack overuse by PMDK with NDCTL enabled and be aligned with Linux page size. `ABT_THREAD_STACKSIZE=20480` env variable is used to increase the default ULT stack size. This env variable is set by control/server module just before engine is started. Much bigger stack is used for pmempool open/create-related tasks e.g. `tgt_vos_create_one` to avoid stack overusage. This modification shall not affect md-on-ssd mode as long as `storage class: "ram"` is used for the first tier in the `storage` configuration. This change does not require any configuration changes to existing systems. The new PMDK package with NDCTL enabled (daos-stack/pmdk#38) will land as soon as this PR is merged. Change-Id: If4c3f7d88a97e4e4f5526da71f4b374a2844057b Signed-off-by: Jan Michalski <[email protected]>
This PR prepares DAOS to be used with NDCTL enabled in PMDK, which means:
NDCTL must not be used when non-DCPM (simulate PMem) -
storage class: "ram"
is used:PMEMOBJ_CONF=sds.at_create=0
env variable disables NDCTL features in the PMDKThis change affects all tests run on simulated PMem (e.g. inside VMs).
Some DOAS utility applications may also require
PMEMOBJ_CONF=sds.at_create=0
to be set.The default ULT stack size must be at least 20KiB to avoid stack overuse by PMDK with NDCTL enabled and be aligned with Linux page size.
ABT_THREAD_STACKSIZE=20480
env variable is used to increase the default ULT stack size.This env variable is set by control/server module just before engine is started.
Much bigger stack is used for pmempool open/create-related tasks e.g.
tgt_vos_create_one
to avoid stack overusage.This modification shall not affect md-on-ssd mode as long as
storage class: "ram"
is used for the first tier in thestorage
configuration.This change does not require any configuration changes to existing systems.
The new PMDK package with NDCTL enabled (daos-stack/pmdk#38) will land as soon as this PR is merged.
Based on: #14371
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: