-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAOS-16628 client: reset eq counter to zero after fork() in IL #15187
Conversation
Features: ioil pil4dfs Required-githooks: true Skipped-githooks: codespell Signed-off-by: Lei Huang <[email protected]>
Ticket title is 'counter of event queue should be reset to zero after fork() in interception lib' |
Features: ioil pil4dfs Required-githooks: true Skipped-githooks: codespell Signed-off-by: Lei Huang <[email protected]>
Features: ioil pil4dfs Required-githooks: true Skipped-githooks: codespell Signed-off-by: Lei Huang <[email protected]>
Features: ioil pil4dfs Required-githooks: true Skipped-githooks: codespell Signed-off-by: Lei Huang <[email protected]>
Test stage Functional Hardware Large completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15187/4/testReport/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if you don't do this?
I have not observe any issue in common applications. I saw errors in destroying network contexts in a test code with multiple level of nested fork() due to wrong context counter in child processes. |
@mchaarawi This PR is quite simple. Shall we back port it to 2.6? Thank you! |
sure please make the req. |
The only failed test (intercept_multi_client.py:IorInterceptMultiClient.test_ior_intercept_libpil4dfs) is due to performance noise. All other tests passed. |
… (#15257) Signed-off-by: Lei Huang <[email protected]>
After fork(), child process inherits the value of the counter of event queues, d_eq_count in libpil4dfs and ioil_iog.iog_eq_count in libioil. They need to be reset to zero.
Required-githooks: true
Skipped-githooks: codespell
Before requesting gatekeeper:
Features:
(orTest-tag*
) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper: