Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16487 test: fix dmg c helper for set-faulty changes #15151

Merged
merged 1 commit into from
Sep 20, 2024
Merged

DAOS-16487 test: fix dmg c helper for set-faulty changes #15151

merged 1 commit into from
Sep 20, 2024

Conversation

tanabarr
Copy link
Contributor

@tanabarr tanabarr commented Sep 18, 2024 •
edited
Loading

Fix missing reference to --host in C test helper and update some doc
references.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@tanabarr tanabarr requested review from a team as code owners September 18, 2024 23:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

Ticket title is 'dmg storage must precisely identify NVMe device(s)'
Status is 'Awaiting backport'
Labels: 'lrz,usability,request_for_2.6.1'
https://daosio.atlassian.net/browse/DAOS-16487

@tanabarr tanabarr force-pushed the tanabarr/control-faulty-fixtest branch from d8591e4 to e49c220 Compare September 19, 2024 09:09
@tanabarr tanabarr added the control-plane work on the management infrastructure of the DAOS Control Plane label Sep 19, 2024
@tanabarr tanabarr self-assigned this Sep 19, 2024
daltonbohning
daltonbohning previously approved these changes Sep 19, 2024
View reviewed changes
src/common/tests_dmg_helpers.c
@@ -1393,7 +1393,7 @@ dmg_storage_set_nvme_fault(const char *dmg_config_file,
D_GOTO(out, rc = -DER_NOMEM);
}

args = cmd_push_arg(args, &argcount, " --host-list=%s ", host);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is only used by src/tests/suite/daos_nvme_recovery.c
Which is ran by DaosCoreTestNvme

Since only documentation and that one test are affected, I think:

Test-tag: DaosCoreTestNvme

@tanabarr
DAOS-16487 test: fix dmg c helper for set-faulty changes
2c5772a 
Test-tag: DaosCoreTestNvme
Required-githooks: true

Signed-off-by: Tom Nabarro <[email protected]>
@tanabarr tanabarr force-pushed the tanabarr/control-faulty-fixtest branch from e49c220 to 2c5772a Compare September 19, 2024 13:53
@daosbuild1
Copy link
Collaborator

Test stage NLT on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15151/3/testReport/

@tanabarr tanabarr added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Sep 20, 2024
@tanabarr
Copy link
Contributor Author

https://build.hpdd.intel.com/blue/organizations/jenkins/daos-stack%2Fdaos/detail/PR-15151/3/tests NLT failure looks unrelated to PR changes and indicates Valgrind issue with ACL code

@tanabarr tanabarr requested review from Michael-Hennecke and a team September 20, 2024 10:27
@phender phender requested a review from a team September 20, 2024 13:02
@phender phender merged commit e871ff6 into master Sep 20, 2024
56 of 58 checks passed
@phender phender deleted the tanabarr/control-faulty-fixtest branch September 20, 2024 13:02
tanabarr added a commit that referenced this pull request Oct 7, 2024
@tanabarr
DAOS-16487 test: fix dmg c helper for set-faulty changes (#15151)
0b0e860 
Fix missing reference to --host in C test helper and update some doc
references.

Signed-off-by: Tom Nabarro <[email protected]>
daltonbohning pushed a commit that referenced this pull request Oct 9, 2024
@tanabarr
DAOS-16487 test: fix dmg c helper for set-faulty changes (#15151) (#1…
3ebf80f 
…5261)

Fix missing reference to --host in C test helper and update some doc
references.

Signed-off-by: Tom Nabarro <[email protected]>
@techbasset techbasset mentioned this pull request Oct 14, 2024
Merged
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phender phender phender approved these changes

@daltonbohning daltonbohning daltonbohning approved these changes

@Michael-Hennecke Michael-Hennecke Awaiting requested review from Michael-Hennecke

Assignees

@tanabarr tanabarr

Labels
control-plane work on the management infrastructure of the DAOS Control Plane forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tanabarr @daosbuild1 @daltonbohning @phender @Michael-Hennecke