Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16251 tests: Fix various memory issues #15147

Merged
merged 3 commits into from
Sep 25, 2024
Merged

DAOS-16251 tests: Fix various memory issues #15147

merged 3 commits into from
Sep 25, 2024

Conversation

liw
Copy link
Contributor

@liw liw commented Sep 18, 2024 •
edited
Loading

This patch fixes the following memory issues in daos_test:

  • IO13 (basic_byte_array) may read beyond the end of buf_out.

  • REBUILD6 (rebuild_snap_update_recs) may write beyond the end of
    string.

  • ARRAY19 (test_async_io) may write beyond the end of dkey_str[].

  • daos_start_server can't just increment svc->rl_nr without making
    sure that svc->rl_ranks matches svc->rl_nr.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@liw
DAOS-16251 tests: Fix various memory issues
3d079e6 
This patch fixes the following memory issues in daos_test:

  - IO13 (basic_byte_array) may read beyond the end of buf_out.

  - REBUILD6 (rebuild_snap_update_recs) may write beyond the end of
    string.

  - ARRAY19 (test_async_io) may write beyond the end of dkey_str[].

  - daos_start_server can't just increment svc->rl_nr without making
    sure that svc->rl_ranks matches svc->rl_nr.

Signed-off-by: Li Wei <[email protected]>
Required-githooks: true

DAOS-16251 tests: Fix EC2 use-after-scope

Signed-off-by: Li Wei <[email protected]>
Required-githooks: true
@github-actions GitHub Actions
Copy link

Ticket title is 'DAOS 2.4.2-4: Errored DAOS engine 0 exited unexpectedly on daos_user'
Status is 'In Progress'
Labels: 'ALCF,pre_acceptance_issues'
https://daosio.atlassian.net/browse/DAOS-16251

@liw liw force-pushed the liw/fix-obj-tests branch from 03d1555 to 3d079e6 Compare September 18, 2024 10:21
@liw liw marked this pull request as ready for review September 19, 2024 01:24
liuxuezhao
liuxuezhao previously approved these changes Sep 20, 2024
View reviewed changes
knard38
knard38 previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over all seems good to me.
Just some minor details.

src/tests/suite/daos_obj.c Outdated Show resolved Hide resolved
src/tests/suite/daos_obj_ec.c Show resolved Hide resolved
liw added 2 commits September 24, 2024 09:57
@liw
Address review comments
c822f0f 
Signed-off-by: Li Wei <[email protected]>
Required-githooks: true
@liw
Merge branch 'master' into liw/fix-obj-tests
5b47bc3 
Required-githooks: true
@liw liw dismissed stale reviews from knard38 and liuxuezhao via 5b47bc3 September 24, 2024 00:58
knard38
knard38 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liw liw requested a review from liuxuezhao September 24, 2024 08:44
@liw liw requested a review from a team September 25, 2024 12:41
@mchaarawi mchaarawi merged commit 0dfe144 into master Sep 25, 2024
54 of 55 checks passed
@mchaarawi mchaarawi deleted the liw/fix-obj-tests branch September 25, 2024 14:07
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
@liw liw mentioned this pull request Jan 8, 2025
Draft
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knard38 knard38 knard38 approved these changes

@liuxuezhao liuxuezhao liuxuezhao approved these changes

@wangdi1 wangdi1 Awaiting requested review from wangdi1

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liw @liuxuezhao @knard38 @mchaarawi