Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16560 test: Improve get_service_file() #15116

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

phender
Copy link
Contributor

@phender phender commented Sep 10, 2024

Handle unexpected output when parsing the systemctl service file.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: HarnessCoverageTest

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

Handle unexpected output when parsing the systemctl service file.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: HarnessCoverageTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender phender requested review from a team as code owners September 10, 2024 22:40
Copy link

github-actions bot commented Sep 10, 2024

Ticket title is 'ftest: Failed to setup systemctl config for daos_server.service'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16560

@phender phender changed the title DAOS-16460 test: Improve get_service_file() DAOS-16560 test: Improve get_service_file() Sep 10, 2024
@phender
Copy link
Contributor Author

phender commented Sep 10, 2024

Ticket title is 'LRZ: three engine coredumps 2024-08-28' Status is 'In Progress' Labels: 'LRZ,scrubbed_2.8' https://daosio.atlassian.net/browse/DAOS-16460

Corrected:
https://daosio.atlassian.net/browse/DAOS-16560

@phender
Copy link
Contributor Author

phender commented Sep 11, 2024

Changes are working in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15116/1/artifact/Functional%20on%20EL%208.8/launch/functional_on_el_8.8/job.log:

2024/09/10 10:59:17 INFO        __add_systemctl_override: Setting up systemctl override for daos_server.service
2024/09/10 10:59:17 DEBUG                     run_remote: Running on wolf-106vm[2-9] with a 120 second timeout: systemctl show daos_server.service | grep 'FragmentPath='
2024/09/10 10:59:18 DEBUG                log_result_data:   wolf-106vm[2-9] (rc=0): FragmentPath=/usr/lib/systemd/system/daos_server.service
2024/09/10 10:59:18 DEBUG                     run_remote: Running on wolf-106vm[2-9] with a 120 second timeout: sudo -n mkdir -p /usr/lib/systemd/system/daos_server.service.d
2024/09/10 10:59:18 DEBUG                log_result_data:   wolf-106vm[2-9] (rc=0): <no output>

@phender phender requested a review from a team September 11, 2024 14:10
@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Sep 11, 2024
@daltonbohning daltonbohning merged commit e56eb73 into master Sep 11, 2024
47 checks passed
@daltonbohning daltonbohning deleted the pahender/DAOS-16560 branch September 11, 2024 14:12
phender added a commit that referenced this pull request Sep 11, 2024
Handle unexpected output when parsing the systemctl service file.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: HarnessCoverageTest

Signed-off-by: Phil Henderson <[email protected]>
mjmac pushed a commit that referenced this pull request Sep 12, 2024
Handle unexpected output when parsing the systemctl service file.

Signed-off-by: Phil Henderson <[email protected]>
mjmac added a commit that referenced this pull request Sep 12, 2024
Handle unexpected output when parsing the systemctl service file.

Signed-off-by: Phil Henderson <[email protected]>
daltonbohning pushed a commit that referenced this pull request Sep 17, 2024
Handle unexpected output when parsing the systemctl service file.

Skip-test: true
Skip-build: true

Signed-off-by: Phil Henderson <[email protected]>
Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning pushed a commit that referenced this pull request Sep 18, 2024
Handle unexpected output when parsing the systemctl service file.

Signed-off-by: Phil Henderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Development

Successfully merging this pull request may close these issues.

3 participants