DAOS-14419 control: Display disabled ranks by default

[knard-intel]

Description

Always display the disabled targets and remove the old associated options.

Required-githooks: true

Before requesting gatekeeper:

• Two review approvals and any prior change requests have been resolved.
• Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
• Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
• Commit messages follows the guidelines outlined here.
• Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

• You are the appropriate gatekeeper to be landing the patch.
• The PR has 2 reviews by people familiar with the code, including appropriate owners.
• Githooks were used. If not, request that user install them and check copyright dates.
• Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
• All builds have passed. Check non-required builds for any new compiler warnings.
• Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
• If applicable, the PR has addressed any potential version compatibility issues.
• Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
• Extra checks if forced landing is requested
  • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
  • No new NLT or valgrind warnings. Check the classic view.
  • Quick-build or Quick-functional is not used.
• Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

[github-actions]

Ticket title is 'Display disabled ranks by default'
Status is 'In Progress'
Labels: 'google-cloud-daos,lrz,triaged,usability'
https://daosio.atlassian.net/browse/DAOS-14419

[daosbuild1]

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15112/2/testReport/

[daosbuild1]

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15112/3/testReport/

[daosbuild1]

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15112/3/execution/node/1215/log

[daosbuild1]

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15112/3/execution/node/1524/log

[daosbuild1]

Test stage Functional Hardware Medium completed with status UNSTABLE. https://build.hpdd.intel.com/job/daos-stack/job/daos//view/change-requests/job/PR-15112/3/testReport/

[daosbuild1]

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15112/5/execution/node/1417/log

[mjmac]

The code changes LGTM. I wonder if Features: control is enough to validate the test changes, though. @daltonbohning: Do the changed tests get auto-added now?

[knard-intel]

@daltonbohning , could you tell me if the functional test part is OK for you ?
If not please, could you tell me if there is some other Features tags that I should add.

[daltonbohning]

ftest LGTM

[daltonbohning]

The code changes LGTM. I wonder if Features: control is enough to validate the test changes, though. @daltonbohning: Do the changed tests get auto-added now?

Changes to ftest/util map to pr, so don't necessarily cover affected tests. But changes to specific tests do include those specific tests. In this case, I think Features: control is probably sufficient since tests referencing disabled_ranks were updated.

[knard-intel]

@daos-stack/daos-gatekeeper please could you land this PR with the following message:

• Title: DAOS-14419 control: Display disabled ranks by default
• Body:
  Always display the disabled targets and remove the old associated options.