Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16495 test: Use the test env control config file w/ dmg #15094

Merged
merged 6 commits into from
Sep 18, 2024
Merged

DAOS-16495 test: Use the test env control config file w/ dmg #15094

merged 6 commits into from
Sep 18, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Sep 6, 2024

Use the TestEnvironment.conftrol.config file by default with the DmgCommand object when a config file is not specified.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DmgNvmeScanTest ConfigGenerateOutput ConfigGenerateRun HarnessConfigTest

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@phender
DAOS-16495 test: Use the test env control config file w/ dmg
52c1b86 
Use the TestEnvironment.conftrol.config file by default with the
DmgCommand object when a config file is not specified.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DmgNvmeScanTest ConfigGenerateOutput ConfigGenerateRun HarnessConfigTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender phender requested review from a team as code owners September 6, 2024 19:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024 •
edited
Loading

Ticket title is 'Several control/config_generate_output.py tests fail on weekly testing stating localhost with connection refused error.'
Status is 'In Progress'
Labels: '2.6.1rc1,ci_master_weekly,weekly_test'
https://daosio.atlassian.net/browse/DAOS-16495

@daosbuild1
Copy link
Collaborator

Test stage Functional on EL 8.8 completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15094/1/execution/node/823/log

@phender
Update harness/config.py server setup for VMs.
974fdf6 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DmgNvmeScanTest ConfigGenerateOutput ConfigGenerateRun HarnessConfigTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender
Cleaner fix.
0ea1251 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DmgNvmeScanTest ConfigGenerateOutput ConfigGenerateRun HarnessConfigTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15094/4/execution/node/1077/log

daltonbohning
daltonbohning previously approved these changes Sep 9, 2024
View reviewed changes
@phender
Merge branch 'master' into pahender/DAOS-16495
6c60662
@phender
Fix control_metadata_path specification for config generate.
8e52e35 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DmgNvmeScanTest ConfigGenerateOutput ConfigGenerateRun HarnessConfigTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender phender mentioned this pull request Sep 17, 2024
Closed
18 tasks
@phender
Fix typo.
008c974 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DmgNvmeScanTest ConfigGenerateOutput ConfigGenerateRun HarnessConfigTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
phender
phender commented Sep 17, 2024
View reviewed changes
src/tests/ftest/control/config_generate_run.py
@@ -4,6 +4,8 @@
SPDX-License-Identifier: BSD-2-Clause-Patent
'''

import os

Copy link
Contributor Author

@phender phender Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isort would complain unless the new line was here for some reason

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because os is internal and yaml is 3rd-party (pip installed or dnf isntalled) so isort wants those group separately

phender
phender commented Sep 17, 2024
View reviewed changes
src/tests/ftest/control/config_generate_run.py
@@ -45,16 +47,16 @@ def test_config_generate_run(self):

# use_tmpfs_scm specifies that a MD-on-SSD conf should be generated and control metadata
# path needs to be set in that case.
ext_md_path = ""
control_metadata = None
Copy link
Contributor Author

@phender phender Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should avoid running config generate with an empty --control-metadata-path argument - not that it was causing problems, e.g.

/usr/bin/dmg -o /var/tmp/daos_testing/configs/daos_control.yml -d config generate --access-points=wolf-219 --control-metadata-path= --net-provider=ofi+tcp

@phender
Copy link
Contributor Author

phender commented Sep 18, 2024

All tests passed in https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15094/6/testReport/FTEST_control/ and https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-15094/6/testReport/FTEST_harness/

@phender phender requested a review from a team September 18, 2024 15:40
@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Sep 18, 2024
@daltonbohning daltonbohning merged commit acfa271 into master Sep 18, 2024
47 checks passed
@daltonbohning daltonbohning deleted the pahender/DAOS-16495 branch September 18, 2024 16:09
phender added a commit that referenced this pull request Sep 18, 2024
@phender
DAOS-16495 test: Use the test env control config file w/ dmg (#15094)
c356542 
Use the TestEnvironment.conftrol.config file by default with the
DmgCommand object when a config file is not specified.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: DmgNvmeScanTest ConfigGenerateOutput ConfigGenerateRun HarnessConfigTest

Signed-off-by: Phil Henderson <[email protected]>
daltonbohning pushed a commit that referenced this pull request Sep 20, 2024
@phender
DAOS-16495 test: Use the test env control config file w/ dmg (#15094) (…
c2eec1b 
…#15149)

Use the TestEnvironment.conftrol.config file by default with the
DmgCommand object when a config file is not specified.

Signed-off-by: Phil Henderson <[email protected]>
@jolivier23 jolivier23 mentioned this pull request Sep 24, 2024
Merged
@mjmac mjmac mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

@shimizukko shimizukko shimizukko approved these changes

@rpadma2 rpadma2 Awaiting requested review from rpadma2

@mjean308 mjean308 Awaiting requested review from mjean308

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phender @daosbuild1 @shimizukko @daltonbohning