Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16271 mercury: Add patch to check ep for null in UCX key resolve. #15077

Merged
merged 1 commit into from
Sep 5, 2024
Merged

DAOS-16271 mercury: Add patch to check ep for null in UCX key resolve. #15077

merged 1 commit into from
Sep 5, 2024

Conversation

jgmoore-or
Copy link
Contributor

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

Ticket title is 'LRZ: m02r01s01dao engine coredump 24-Jul-2024'
Status is 'In Review'
Labels: 'lrz'
https://daosio.atlassian.net/browse/DAOS-16271

@jgmoore-or jgmoore-or added the release-2.6.1 Targeted for release 2.6.1 label Sep 5, 2024
@mchaarawi mchaarawi merged commit 3d9e2d0 into release/2.6 Sep 5, 2024
48 of 49 checks passed
@mchaarawi mchaarawi deleted the jgm/DAOS-16271-2.6 branch September 5, 2024 20:39
@mjmac mjmac mentioned this pull request Sep 9, 2024
Merged
mjmac added a commit that referenced this pull request Sep 9, 2024
@mjmac
Revert "DAOS-16271 mercury: Add patch to check ep for null in UCX key…
0790fa9 
… resolve. (#15077)"

Not needed in our build (b/364929445).

This reverts commit 3d9e2d0.
mjmac added a commit that referenced this pull request Sep 9, 2024
@mjmac
Revert "DAOS-16271 mercury: Add patch to check ep for null in UCX key…
f2c36ad 
… resolve. (#15077)"

Not needed in our build (b/364929445).

This reverts commit 3d9e2d0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostedcmos frostedcmos frostedcmos approved these changes

@soumagne soumagne Awaiting requested review from soumagne

Assignees
No one assigned
Labels
release-2.6.1 Targeted for release 2.6.1
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgmoore-or @frostedcmos @mchaarawi