Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-16483 vos: handle empty DTX when vos_tx_end - b26 #15055

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Nasf-Fan
Copy link
Contributor

@Nasf-Fan Nasf-Fan commented Sep 1, 2024

It is possible that the DTX modified nothing when stop currnet backend transaction. Under such case, we may not generate persistent DTX entry. Then need to bypass such case before checking on-disk DTX entry status.

The patch makes some clean and removed redundant metrics for committed DTX entries.

Enhance vos_dtx_deregister_record() to handle GC case.

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

It is possible that the DTX modified nothing when stop currnet backend
transaction. Under such case, we may not generate persistent DTX entry.
Then need to bypass such case before checking on-disk DTX entry status.

The patch makes some clean and removed redundant metrics for committed
DTX entries.

Enhance vos_dtx_deregister_record() to handle GC case.

Signed-off-by: Fan Yong <[email protected]>
Copy link

github-actions bot commented Sep 1, 2024

Ticket title is 'Segmentation fault inside vos_tx_end() when handle empty DTX'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-16483

@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15055/1/execution/node/1551/log

@Nasf-Fan Nasf-Fan marked this pull request as ready for review September 2, 2024 02:55
@Nasf-Fan Nasf-Fan requested review from a team as code owners September 2, 2024 02:55
@Nasf-Fan
Copy link
Contributor Author

Nasf-Fan commented Sep 2, 2024

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15055/1/execution/node/1551/log

Some PMEM hardware issue caused test CI failure, not related with the patch.

@Nasf-Fan Nasf-Fan removed request for a team September 2, 2024 02:56
Copy link
Contributor

@daltonbohning daltonbohning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftest LGTM

@Nasf-Fan Nasf-Fan added release-2.6.1 Targeted for release 2.6.1 forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. clean-cherry-pick Cherry-pick from another branch that did not require additional edits labels Sep 5, 2024
@gnailzenh gnailzenh merged commit 906f0a4 into release/2.6 Sep 5, 2024
49 of 52 checks passed
@gnailzenh gnailzenh deleted the Nasf-Fan/DAOS-16483_b26 branch September 5, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. release-2.6.1 Targeted for release 2.6.1
Development

Successfully merging this pull request may close these issues.

5 participants