Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16463 test: remove get_host_log_files (#15030) #15040

Merged
merged 1 commit into from
Aug 30, 2024
Merged

DAOS-16463 test: remove get_host_log_files (#15030) #15040

merged 1 commit into from
Aug 30, 2024

Conversation

daltonbohning
Copy link
Contributor

Remove get_host_log_files since it is no longer needed. Also remove search_log which used get_host_log_files and is unused.

Test-tag: test_basic_coverage
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning
DAOS-16463 test: remove get_host_log_files (#15030)
cc35bfc 
Remove get_host_log_files since it is no longer needed.
Also remove search_log which used get_host_log_files and is unused.

Test-tag: test_basic_coverage
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Aug 29, 2024
@daltonbohning daltonbohning self-assigned this Aug 29, 2024
daltonbohning added a commit that referenced this pull request Aug 29, 2024
@daltonbohning
DAOS-16463 test: remove get_host_log_files (#15030) #15040
10d4f36 
Remove get_host_log_files since it is no longer needed.
Also remove search_log which used get_host_log_files and is unused.

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@github-actions GitHub Actions
Copy link

Ticket title is 'ftest: remove get_host_files'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-16463

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Aug 29, 2024
@daltonbohning daltonbohning marked this pull request as ready for review August 29, 2024 21:36
@daltonbohning daltonbohning requested review from a team as code owners August 29, 2024 21:36
@daltonbohning daltonbohning requested a review from a team August 30, 2024 14:18
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 30, 2024
@daltonbohning daltonbohning merged commit a176bc5 into release/2.6 Aug 30, 2024
43 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-16463-2.6 branch August 30, 2024 14:18
@jolivier23 jolivier23 mentioned this pull request Sep 4, 2024
Merged
daltonbohning added a commit that referenced this pull request Sep 5, 2024
@daltonbohning
DAOS-16463 test: remove get_host_log_files (#15030) #15040
b2e0726 
Remove get_host_log_files since it is no longer needed.
Also remove search_log which used get_host_log_files and is unused.

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpadma2 rpadma2 rpadma2 approved these changes

@shimizukko shimizukko shimizukko approved these changes

@phender phender Awaiting requested review from phender

Assignees

@daltonbohning daltonbohning

Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daltonbohning @shimizukko @rpadma2