Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-16366 test: Use agent/server config files from test directory (#14944) #15033

Merged
merged 4 commits into from
Aug 30, 2024
Merged

DAOS-16366 test: Use agent/server config files from test directory (#14944) #15033

merged 4 commits into from
Aug 30, 2024

Conversation

phender
Copy link
Contributor

@phender phender commented Aug 29, 2024

Use agent, control, and server config files placed in the common test directory instead of /etc/daos with a systemctl override configuration file.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr test_setup_vm DdbTest DaosCoreTestDfuse DestroyTests DaosAgentSupportCollectLogTest DaosServerSupportCollectLogTest

Required-githooks: true

Signed-off-by: Phil Henderson [email protected]

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

phender added 2 commits August 28, 2024 21:26
@phender
DAOS-16265 test: Add debug for common test dir between variants (#14818)
ef993c1 
Help determine contents of common test dir between test variants.

Signed-off-by: Phil Henderson <[email protected]>
@phender
DAOS-16366 test: Use agent/server config files from test directory (#…
555085a 
…14944)

Use agent, control, and server config files placed in the common test directory instead of /etc/daos with a systemctl override configuration file.

Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr test_setup_vm DdbTest DaosCoreTestDfuse DestroyTests DaosAgentSupportCollectLogTest DaosServerSupportCollectLogTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender phender added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Aug 29, 2024
@github-actions GitHub Actions
Copy link

Ticket title is 'ftest: run agent/server commands with config files sourced from test directory'
Status is 'Awaiting backport'
Labels: 'request_for_2.6.1'
https://daosio.atlassian.net/browse/DAOS-16366

phender added 2 commits August 29, 2024 10:04
@phender
Fix systemctl --user usage
89cb4bf 
Skip-unit-tests: true
Skip-fault-injection-test: true

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender
Undo unintended push.
ba0fa38 
Skip-unit-tests: true
Skip-fault-injection-test: true
Test-tag: pr test_setup_vm DdbTest DaosCoreTestDfuse DestroyTests DaosAgentSupportCollectLogTest DaosServerSupportCollectLogTest

Required-githooks: true

Signed-off-by: Phil Henderson <[email protected]>
@phender phender marked this pull request as ready for review August 29, 2024 16:53
@phender phender requested review from a team as code owners August 29, 2024 16:53
@phender phender requested a review from daltonbohning August 29, 2024 16:53
@daosbuild1
Copy link
Collaborator

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15033/3/execution/node/1154/log

@phender
Copy link
Contributor Author

phender commented Aug 30, 2024

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-15033/3/execution/node/1154/log

The two failures are https://daosio.atlassian.net/browse/DAOS-16464

@phender phender requested a review from a team August 30, 2024 14:08
@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Aug 30, 2024
@daltonbohning daltonbohning merged commit cf7322a into release/2.6 Aug 30, 2024
44 of 46 checks passed
@daltonbohning daltonbohning deleted the pahender/DAOS-16366 branch August 30, 2024 14:24
@jolivier23 jolivier23 mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

Assignees
No one assigned
Labels
clean-cherry-pick Cherry-pick from another branch that did not require additional edits forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phender @daosbuild1 @daltonbohning