DAOS-16451 telemetry: Adjust type of (_sum|_sumsquares) #15028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These stats metrics should be Counter rather than Gauge, as their values will only increase. Also includes a small fix for pem_test.go to set the test dir permissions explicitly irrespective of umask. Features: telemetry Required-githooks: true Change-Id: Iaae589189a5fc60b58ce4ba05262763a88956fcf Signed-off-by: Michael MacDonald <[email protected]>
|
Ticket title is 'Make _sum in metric stats a counter instead of a gauge' |
kjacque
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These stats metrics should be Counter rather than Gauge,
as their values will only increase.
Also includes a small fix for pem_test.go to set the
test dir permissions explicitly irrespective of umask.
Features: telemetry
Required-githooks: true
Change-Id: Iaae589189a5fc60b58ce4ba05262763a88956fcf
Signed-off-by: Michael MacDonald [email protected]